* [PATCH] PCI: mvebu: Use max_t() instead of max(resource_size_t,)
@ 2013-12-27 0:34 Jingoo Han
2013-12-27 17:34 ` Jason Cooper
2014-01-02 21:44 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-12-27 0:34 UTC (permalink / raw)
To: 'Bjorn Helgaas'
Cc: linux-pci, 'Thomas Petazzoni', 'Jason Cooper',
'Jingoo Han'
Use max_t() instead of max(resource_size_t,) in order to fix
the following checkpatch warning.
WARNING: max() should probably be max_t(resource_size_t, SZ_64K, size)
WARNING: max() should probably be max_t(resource_size_t, SZ_1M, size)
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pci/host/pci-mvebu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
index bedc0b1..fa140e1 100644
--- a/drivers/pci/host/pci-mvebu.c
+++ b/drivers/pci/host/pci-mvebu.c
@@ -735,9 +735,9 @@ static resource_size_t mvebu_pcie_align_resource(struct pci_dev *dev,
* aligned on their size
*/
if (res->flags & IORESOURCE_IO)
- return round_up(start, max((resource_size_t)SZ_64K, size));
+ return round_up(start, max_t(resource_size_t, SZ_64K, size));
else if (res->flags & IORESOURCE_MEM)
- return round_up(start, max((resource_size_t)SZ_1M, size));
+ return round_up(start, max_t(resource_size_t, SZ_1M, size));
else
return start;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: mvebu: Use max_t() instead of max(resource_size_t,)
2013-12-27 0:34 [PATCH] PCI: mvebu: Use max_t() instead of max(resource_size_t,) Jingoo Han
@ 2013-12-27 17:34 ` Jason Cooper
2014-01-02 21:44 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Jason Cooper @ 2013-12-27 17:34 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Bjorn Helgaas', linux-pci, 'Thomas Petazzoni'
On Fri, Dec 27, 2013 at 09:34:36AM +0900, Jingoo Han wrote:
> Use max_t() instead of max(resource_size_t,) in order to fix
> the following checkpatch warning.
>
> WARNING: max() should probably be max_t(resource_size_t, SZ_64K, size)
> WARNING: max() should probably be max_t(resource_size_t, SZ_1M, size)
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/pci/host/pci-mvebu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Jason Cooper <jason@lakedaemon.net>
thx,
Jason.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: mvebu: Use max_t() instead of max(resource_size_t,)
2013-12-27 0:34 [PATCH] PCI: mvebu: Use max_t() instead of max(resource_size_t,) Jingoo Han
2013-12-27 17:34 ` Jason Cooper
@ 2014-01-02 21:44 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2014-01-02 21:44 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-pci, 'Thomas Petazzoni', 'Jason Cooper'
On Fri, Dec 27, 2013 at 09:34:36AM +0900, Jingoo Han wrote:
> Use max_t() instead of max(resource_size_t,) in order to fix
> the following checkpatch warning.
>
> WARNING: max() should probably be max_t(resource_size_t, SZ_64K, size)
> WARNING: max() should probably be max_t(resource_size_t, SZ_1M, size)
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied with Jason's ack to pci/host-mvebu for v3.14, thanks!
Bjorn
> ---
> drivers/pci/host/pci-mvebu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
> index bedc0b1..fa140e1 100644
> --- a/drivers/pci/host/pci-mvebu.c
> +++ b/drivers/pci/host/pci-mvebu.c
> @@ -735,9 +735,9 @@ static resource_size_t mvebu_pcie_align_resource(struct pci_dev *dev,
> * aligned on their size
> */
> if (res->flags & IORESOURCE_IO)
> - return round_up(start, max((resource_size_t)SZ_64K, size));
> + return round_up(start, max_t(resource_size_t, SZ_64K, size));
> else if (res->flags & IORESOURCE_MEM)
> - return round_up(start, max((resource_size_t)SZ_1M, size));
> + return round_up(start, max_t(resource_size_t, SZ_1M, size));
> else
> return start;
> }
> --
> 1.7.10.4
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-02 21:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-27 0:34 [PATCH] PCI: mvebu: Use max_t() instead of max(resource_size_t,) Jingoo Han
2013-12-27 17:34 ` Jason Cooper
2014-01-02 21:44 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).