From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Myron Stowe <myron.stowe@redhat.com>
Subject: Re: [PATCH pci-next 2/2] pci: remove dead code
Date: Mon, 6 Jan 2014 08:47:16 -0800 [thread overview]
Message-ID: <20140106084716.068edc9f@jbarnes-desktop> (raw)
In-Reply-To: <CAErSpo49y7q_E4kHtFsZ-hOkbeWaAgEAt38YdP1TJ6Dk0XwOWw@mail.gmail.com>
On Thu, 2 Jan 2014 16:12:52 -0700
Bjorn Helgaas <bhelgaas@google.com> wrote:
> [+cc Jesse, Myron]
>
> On Fri, Dec 27, 2013 at 2:27 PM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > My philosophy is unused code is dead code.
> > And dead code is subject to bit rot and is likely source of bugs.
> > Use it or lose it.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> This removes pci_enable_ido(), pci_enable_obff(), pci_enable_ltr(),
> etc., which I think you added, Jesse. In principle I like the idea of
> removing code that isn't being used. Of course, these might be used
> by out-of-tree drivers, but I don't think we should go *too* far out
> of our way to support them.
>
> Anybody have any objections to removing them? Obviously they'll still
> be in the git history, so it would be trivial to resurrect them.
No objections. If driver folks haven't yet found a use for them (and/or
hw is scarce) there's no reason to keep these.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-01-06 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20131227132530.5c02d9d8@nehalam.linuxnetplumber.net>
2013-12-27 21:27 ` [PATCH pci-next 2/2] pci: remove dead code Stephen Hemminger
2014-01-02 23:12 ` Bjorn Helgaas
2014-01-06 16:47 ` Jesse Barnes [this message]
2014-01-11 1:05 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106084716.068edc9f@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=myron.stowe@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).