Re: mlx4_core probe error after applying Yinghai's patch

[Wei Yang <weiyang@linux.vnet.ibm.com>]

On Wed, Jan 29, 2014 at 10:50:30AM +0200, Or Gerlitz wrote:
>On 16/01/2014 04:14, Wei Yang wrote:
>>>>>+static void mlx4_shutdown(struct pci_dev *pdev)
>>>>>+{
>>>>>+       mlx4_remove_one(pdev);
>>>>>+}
>>>>>+
>>>>>  int mlx4_restart_one(struct pci_dev *pdev)
>>>>>  {
>>>>>         struct mlx4_dev  *dev  = pci_get_drvdata(pdev);
>>>>>@@ -2582,6 +2590,7 @@ static struct pci_driver mlx4_driver = {
>>>>>         .id_table       = mlx4_pci_table,
>>>>>         .probe          = mlx4_init_one,
>>>>>         .remove         = mlx4_remove_one,
>>>>>+       .shutdown       = mlx4_shutdown,
>>>>>         .err_handler    = &mlx4_err_handler,
>>>>>  };
>>>>>
>>>>>Thanks,
>>>>>Gavin
>
>Guys,
>
>Did you converge here?  I don't see this patch in Linus tree, so
>wasn't sure where the discussion went eventually.

Or,

Even this patch really could make the machine boot up, we didn't find the root 
cause of the failure as mentioned in the first mail. I will find some time to
dig into it if I have more time and will send you update if I find it.

For this patch, we(Gavin and I) don't think it is a formal patch. We send it
here just let you know we find a work around and this one really helps. As I
mentioned in the previous mail, we suggest you guys to create a formal patch
with this function, since you are more familiar with this device and the
driver.

If you think it would be nice for a patch from us, I am very glad to do
this.:-)

>
>Or.
>
>Or.

-- 
Richard Yang
Help you, Help me