From: Tejun Heo <tj@kernel.org>
To: Peter Chang <dpf@google.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: PATCH: platforms: avoid queuing work if possible
Date: Mon, 10 Feb 2014 17:41:58 -0500 [thread overview]
Message-ID: <20140210224158.GF25350@mtj.dyndns.org> (raw)
In-Reply-To: <CAF2xp_F_WeMOhffLv+tA2O8L6+8Vn=VZtNh3S4WXmEAMEQC-jw@mail.gmail.com>
Hello, Peter.
On Tue, Feb 04, 2014 at 08:13:58PM -0800, Peter Chang wrote:
> the problem is that our current user-space environment expects block
> devices to be in /sys/block after the module load completes. if the
> cross cpu worker task is marked w/ ASYNC_USED (rather than the module
> loading task), module loading completes and the async tasks are
> 'racing' w/ user space.
>
> i fixed up the patch to just do the ASYNC_USED copying in the worker
> function (since there was some bogus-ness in the original w/
> get_cpu()). does this patch make more sense?
Heh, this is almost inherently nasty. The whole thing is a nasty hack
after all. :( Would it be possible to make work_on_cpu() do the
copying instead? That might be a bit cleaner and I think it could be
better to keep the work around in async / workqueue side rather than
specific drivers.
Thanks.
--
tejun
prev parent reply other threads:[~2014-02-10 22:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 1:24 PATCH: platforms: avoid queuing work if possible Peter Chang
2014-01-31 11:53 ` Tejun Heo
2014-01-31 12:00 ` Tejun Heo
2014-02-05 4:13 ` Peter Chang
2014-02-10 22:41 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210224158.GF25350@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=dpf@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).