From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f177.google.com ([209.85.223.177]:50336 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721AbaBNSXU (ORCPT ); Fri, 14 Feb 2014 13:23:20 -0500 Received: by mail-ie0-f177.google.com with SMTP id rp18so2770097iec.36 for ; Fri, 14 Feb 2014 10:23:20 -0800 (PST) Date: Fri, 14 Feb 2014 11:23:16 -0700 From: Bjorn Helgaas To: Yijing Wang Cc: Russell King , David Airlie , dri-devel@lists.freedesktop.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-pcmcia@lists.infradead.org, linux-pci@vger.kernel.org, Hanjun Guo Subject: Re: [PATCH 1/6] PCI,acpiphp: Use list_for_each_entry() for bus traversal Message-ID: <20140214182316.GB31093@google.com> References: <1392297243-61848-1-git-send-email-wangyijing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1392297243-61848-1-git-send-email-wangyijing@huawei.com> Sender: linux-pci-owner@vger.kernel.org List-ID: On Thu, Feb 13, 2014 at 09:13:58PM +0800, Yijing Wang wrote: > Replace list_for_each() + pci_bus_b() with the simpler > list_for_each_entry(). > > Signed-off-by: Yijing Wang I applied all six of these (please include a 0/6 cover letter in the future; that's a nice place to note that I applied things) to pci/list-for-each-entry for v3.15, thanks! > --- > drivers/pci/hotplug/acpiphp_glue.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c > index cd929ae..aee6a0a 100644 > --- a/drivers/pci/hotplug/acpiphp_glue.c > +++ b/drivers/pci/hotplug/acpiphp_glue.c > @@ -450,7 +450,7 @@ static void cleanup_bridge(struct acpiphp_bridge *bridge) > */ > static unsigned char acpiphp_max_busnr(struct pci_bus *bus) > { > - struct list_head *tmp; > + struct pci_bus *tmp; > unsigned char max, n; > > /* > @@ -463,8 +463,8 @@ static unsigned char acpiphp_max_busnr(struct pci_bus *bus) > */ > max = bus->busn_res.start; > > - list_for_each(tmp, &bus->children) { > - n = pci_bus_max_busnr(pci_bus_b(tmp)); > + list_for_each_entry(tmp, &bus->children, node) { > + n = pci_bus_max_busnr(tmp); > if (n > max) > max = n; > } > -- > 1.7.1 > >