From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f172.google.com ([209.85.213.172]:43363 "EHLO mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752052AbaBRVPl (ORCPT ); Tue, 18 Feb 2014 16:15:41 -0500 Received: by mail-ig0-f172.google.com with SMTP id k19so8052341igc.5 for ; Tue, 18 Feb 2014 13:15:40 -0800 (PST) Date: Tue, 18 Feb 2014 14:15:37 -0700 From: Bjorn Helgaas To: Troy Kisky Cc: Sascha Hauer , Marek Vasut , linux-pci@vger.kernel.org, kernel@pengutronix.de, Richard Zhu , Shawn Guo , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PCI: imx6: Fix link_up detection Message-ID: <20140218211537.GC8786@google.com> References: <1392190075-23204-1-git-send-email-s.hauer@pengutronix.de> <201402120836.16221.marex@denx.de> <52FD0F1A.4000208@boundarydevices.com> <20140214064153.GE17250@pengutronix.de> <52FE6DA7.1010305@boundarydevices.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <52FE6DA7.1010305@boundarydevices.com> Sender: linux-pci-owner@vger.kernel.org List-ID: On Fri, Feb 14, 2014 at 12:25:27PM -0700, Troy Kisky wrote: > On 2/13/2014 11:41 PM, Sascha Hauer wrote: > > On Thu, Feb 13, 2014 at 11:29:46AM -0700, Troy Kisky wrote: > >> On 2/12/2014 12:36 AM, Marek Vasut wrote: > >>> On Wednesday, February 12, 2014 at 08:27:55 AM, Sascha Hauer wrote: > >>> > >>> +CC Troy Kisky, since I think he submitted something similar some time ago > >>> already. > >>> > >>> Otherwise I agree this happens. > >>> > >> Sorry, I haven't submitted this yet, but was planning to today. Here's > >> what would have been sent. > >> > >> From 32c560d33fe2c3945d69f3396689f0abb76f7e1f Mon Sep 17 00:00:00 2001 > >> From: Marek Vasut > >> Date: Sat, 25 Jan 2014 14:22:48 -0700 > >> Subject: [PATCH 1/1] pci-imx6.c: wait for retraining > >> > >> This patch handles the case where the PCIe link is up and running, yet drops > >> into the LTSSM training mode. The link spends short time in the LTSSM training > >> mode, but the current code can misinterpret it as the link being stalled. > >> Waiting for the LTSSM training to complete fixes the issue. > >> > >> Signed-off-by: Marek Vasut > >> Tested-by: Troy Kisky > > > > Thanks, that works. > > > > Tested-by: Sascha Hauer > > > > Sascha > > I don't want to step on your toes, does that means you > expect me to send a formal patch ? I don't care which way we go, but we should make progress on this. It looks like Troy's patch is slightly more extensive (adds comments, uses actual times instead of a CPU speed-dependent wait loop, prints registers for analysis in failure case), so based on that, I would go that route. But we need an ack from Richard or Shawn anyway, so I'll just wait for direction from them. Bjorn