From: Bjorn Helgaas <bhelgaas@google.com>
To: linux-pci@vger.kernel.org
Cc: Markus Lidel <Markus.Lidel@shadowconnect.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] i2o: Fix I/O space allocation copy/paste error
Date: Wed, 26 Feb 2014 12:09:06 -0700 [thread overview]
Message-ID: <20140226190906.9616.52057.stgit@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20140226190306.9616.30567.stgit@bhelgaas-glaptop.roam.corp.google.com>
When i2o_iop_systab_set() allocates I/O port space, it assigns the base of
the new I/O port region to sb->current_mem_base, not sb->current_io_base.
This looks like a copy/paste error, because we do use current_io_base, but
there's no other place that sets it.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/message/i2o/iop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/message/i2o/iop.c b/drivers/message/i2o/iop.c
index a8c08f332da0..a8373d7aaef7 100644
--- a/drivers/message/i2o/iop.c
+++ b/drivers/message/i2o/iop.c
@@ -704,7 +704,7 @@ static int i2o_iop_systab_set(struct i2o_controller *c)
NULL, NULL) >= 0) {
c->io_alloc = 1;
sb->current_io_size = resource_size(res);
- sb->current_mem_base = res->start;
+ sb->current_io_base = res->start;
osm_info("%s: allocated %llu bytes of PCI I/O at "
"0x%016llX.\n", c->name,
(unsigned long long)resource_size(res),
next prev parent reply other threads:[~2014-02-26 19:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 19:08 [PATCH 0/4] i2o: Use pci_bus_alloc_resource() Bjorn Helgaas
2014-02-26 19:09 ` Bjorn Helgaas [this message]
2014-02-26 19:09 ` [PATCH 2/4] i2o: Fix I/O space alignment requirement Bjorn Helgaas
2014-02-26 19:09 ` [PATCH 3/4] i2o: Refactor i2o_iop_systab_set() PCI space allocation Bjorn Helgaas
2014-02-26 19:09 ` [PATCH 4/4] i2o: Use pci_bus_alloc_resource(), not allocate_resource() directly Bjorn Helgaas
2014-02-26 22:48 ` One Thousand Gnomes
2014-02-26 23:47 ` Bjorn Helgaas
2014-03-04 20:52 ` [PATCH 0/4] i2o: Use pci_bus_alloc_resource() Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226190906.9616.52057.stgit@bhelgaas-glaptop.roam.corp.google.com \
--to=bhelgaas@google.com \
--cc=Markus.Lidel@shadowconnect.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).