From: Greg KH <gregkh@linuxfoundation.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/MSI: simplify populate_msi_sysfs()
Date: Thu, 27 Feb 2014 17:21:43 -0800 [thread overview]
Message-ID: <20140228012143.GA9311@kroah.com> (raw)
In-Reply-To: <530F0BD3020000780011FC25@nat28.tlf.novell.com>
On Thu, Feb 27, 2014 at 08:56:35AM +0000, Jan Beulich wrote:
> While originally this was a patch to fix the two memory leaks (which
> got preempted by the two commits that went in the day before I wanted
> to submit this fix), I think this can (and should) be done more
> efficiently:
> - swapping the order of the two allocations and storing the
> msi_dev_attr-derived pointer right after allocation, allowing the
> cleanup code to pick things up without extra effort
> - using kasprintf() instead of the kmalloc()/sprintf() pair
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nice cleanup.
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2014-02-28 1:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 8:56 [PATCH] PCI/MSI: simplify populate_msi_sysfs() Jan Beulich
2014-02-28 1:21 ` Greg KH [this message]
2014-04-04 16:10 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228012143.GA9311@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=JBeulich@suse.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).