From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f50.google.com ([209.85.220.50]:36896 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753512AbaCCKEu (ORCPT ); Mon, 3 Mar 2014 05:04:50 -0500 Received: by mail-pa0-f50.google.com with SMTP id kq14so3591026pab.23 for ; Mon, 03 Mar 2014 02:04:49 -0800 (PST) Date: Mon, 3 Mar 2014 18:04:43 +0800 From: Lee Jones To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, Samuel Ortiz , linux-pci@vger.kernel.org Subject: Re: [PATCH v2] timberdale: Use pci_enable_msix_exact() instead of pci_enable_msix() Message-ID: <20140303100132.GA10579@lee--X1> References: <1392804931-30671-3-git-send-email-agordeev@redhat.com> <20140219114424.GD10504@lee--X1> <20140221165606.GH17353@dhcp-26-207.brq.redhat.com> <20140221165809.GI17353@dhcp-26-207.brq.redhat.com> <20140224162902.GI15847@lee--X1> <20140303072551.GC4674@lee--X1> <20140303081023.GA25705@dhcp-26-207.brq.redhat.com> <20140303092600.GB8282@lee--X1> <20140303093318.GB25705@dhcp-26-207.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20140303093318.GB25705@dhcp-26-207.brq.redhat.com> Sender: linux-pci-owner@vger.kernel.org List-ID: > > > > > Applied, thanks. > > > > > > > > I've reverted this patch, as it doesn't build othognally. > > > > > > > > drivers/mfd/timberdale.c:718:2: > > > > error: implicit declaration of function ‘pci_enable_msix_exact’ > > > > [-Werror=implicit-function-declaration] > > > > > > I should have to clarify it I think. Do you build on top of 3.14-rc4? > > > > Not yet. Is the required patch in there? > > Yep - commit 302a252 ("PCI/MSI: Add pci_enable_msi_range() and > pci_enable_msix_range()"). Okay, seems to work fine post-rebase. Reapplied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog