linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Gordeev <agordeev@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Vinod Koul <vinod.koul@intel.com>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	linux-pci@vger.kernel.org
Subject: [PATCH v2] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()
Date: Fri, 7 Mar 2014 08:49:32 +0100	[thread overview]
Message-ID: <20140307074932.GC2670@dhcp-26-207.brq.redhat.com> (raw)
In-Reply-To: <CAPcyv4ivvxHvyT_5oybVvRJAUKABQQ1ZH4Eua-1KVDeri5kpkA@mail.gmail.com>

As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range()  or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.

Function pci_enable_msix() returns a tri-state value while
pci_enable_msi_exact() is a canonical zero/-errno variant.
The former is being phased out in favor of the latter.
In case of 'ioat' there (should be) no difference.

Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: dmaengine@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Acked-by: Dan Williams <dan.j.williams@intel.com>
---
 drivers/dma/ioat/dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
index 4e3549a..b76c148 100644
--- a/drivers/dma/ioat/dma.c
+++ b/drivers/dma/ioat/dma.c
@@ -947,7 +947,7 @@ msix:
 	for (i = 0; i < msixcnt; i++)
 		device->msix_entries[i].entry = i;
 
-	err = pci_enable_msix(pdev, device->msix_entries, msixcnt);
+	err = pci_enable_msix_exact(pdev, device->msix_entries, msixcnt);
 	if (err)
 		goto msi;
 
-- 
1.7.7.6

-- 
Regards,
Alexander Gordeev
agordeev@redhat.com

  reply	other threads:[~2014-03-07  7:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1394128952.git.agordeev@redhat.com>
2014-03-06 20:11 ` [PATCH v2 RESEND 1/4] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-03-06 21:09   ` Dan Williams
2014-03-06 21:43     ` Alexander Gordeev
2014-03-06 21:50       ` Dan Williams
2014-03-07  7:49         ` Alexander Gordeev [this message]
2014-04-21 13:36           ` [PATCH v2] " Alexander Gordeev
2014-08-25 16:35           ` Alexander Gordeev
2014-08-25 16:31             ` Dan Williams
2014-03-06 20:11 ` [PATCH v2 RESEND 2/4] portdrv: " Alexander Gordeev
2014-03-13  3:56   ` Bjorn Helgaas
2014-04-14 16:18     ` Alexander Gordeev
2014-03-06 20:11 ` [PATCH v2 RESEND 3/4] tsi721: " Alexander Gordeev
2014-03-07 13:35   ` Bounine, Alexandre
2014-04-21 13:28     ` Alexander Gordeev
2014-03-06 20:11 ` [PATCH v2 RESEND 4/4] xhci: " Alexander Gordeev
2014-03-06 21:56   ` Sarah Sharp
2014-03-07  7:46     ` [PATCH v2 1/2] xhci: Cleanup xhci_setup_msi() and xhci_setup_msix() Alexander Gordeev
2014-03-07  7:48     ` [PATCH v2 2/2] xhci: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-03-25 14:27     ` [PATCH v2 RESEND 4/4] " Alexander Gordeev
2014-04-02 11:41       ` Alexander Gordeev
2014-04-02 14:05         ` Mathias Nyman
2014-04-02 15:20           ` Alexander Gordeev
2014-02-19 10:15 [PATCH] ioat: Use pci_enable_msix_range() " Alexander Gordeev
2014-02-21 16:21 ` [PATCH v2] ioat: Use pci_enable_msix_exact() " Alexander Gordeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140307074932.GC2670@dhcp-26-207.brq.redhat.com \
    --to=agordeev@redhat.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).