linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Gordeev <agordeev@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-kernel@vger.kernel.org, Mike Miller <mike.miller@hp.com>,
	iss_storagedev@hp.com, linux-pci@vger.kernel.org,
	Keith Busch <keith.busch@intel.com>,
	Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH v2 0/2] block: Use pci_enable_msix_exact() instead of pci_enable_msix()
Date: Thu, 13 Mar 2014 18:36:57 +0100	[thread overview]
Message-ID: <20140313173656.GA4939@dhcp-26-207.brq.redhat.com> (raw)
In-Reply-To: <5321CE94.5070506@kernel.dk>

On Thu, Mar 13, 2014 at 09:28:20AM -0600, Jens Axboe wrote:
> On 03/12/2014 10:12 PM, Bjorn Helgaas wrote:
> >On Wed, Feb 26, 2014 at 10:02:40AM +0100, Alexander Gordeev wrote:
> >>Changes since v1:
> >>   - cciss: patch #1: a weird 'goto' removed;
> >>   - cciss: patch #2: pci_enable_msix_exact() used, not pci_enable_msix_range();
> >>   - rsxx: patch dropped - no need to change anything;
> >>
> >>As result of deprecation of MSI-X/MSI enablement functions
> >>pci_enable_msix() and pci_enable_msi_block() all drivers
> >>using these two interfaces need to be updated to use the
> >>new pci_enable_msi_range()  or pci_enable_msi_exact()
> >>and pci_enable_msix_range() or pci_enable_msix_exact()
> >>interfaces.
> >>
> >>This change updates 'cciss' only, but there is also 'nvme' update
> >>pending - I am waiting for Intel guys to clarify if they want to
> >>route it thru their tree. If not, I will post the 'nvme' patch as
> >>a follow-up to this series.
> >
> >Hi Jens,
> >
> >I'd like to get these merged during the v3.15 merge window.  I'd be glad to
> >review and apply them through my tree, unless you want to do it.  They do
> >depend on f7fc32c, which went in after the v3.14 merge window, which makes
> >it a bit of a hassle.
> 
> My 3.15/drivers (and core) branch are based off 3.14-rc3, so it
> should be OK. I've queued them up, as it's mostly a followup to the
> previous ones from Alexander.

Oh-oh, cciss patch #2 requires commit 3ce4e86 ("PCI/MSI: Add
pci_enable_msi_exact() and pci_enable_msix_exact()") which was
pulled to 3.14-rc4 only. Sorry for failing to clarify that :(

And I also notice 3111cc3 ("skd: Use pci_enable_msix_exact() instead
of pci_enable_msix_range()") in your tree also should not compile :(

> -- 
> Jens Axboe
> 

-- 
Regards,
Alexander Gordeev
agordeev@redhat.com

  parent reply	other threads:[~2014-03-13 17:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26  9:02 [PATCH v2 0/2] block: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-02-26  9:02 ` [PATCH v2 1/2] cciss: Fallback to MSI rather than to INTx if MSI-X failed Alexander Gordeev
2014-02-26  9:02 ` [PATCH v2 2/2] cciss: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-03-04 15:22 ` [PATCH v2 3/2] nvme: Use pci_enable_msi_range() and pci_enable_msix_range() Alexander Gordeev
2014-03-13  4:12 ` [PATCH v2 0/2] block: Use pci_enable_msix_exact() instead of pci_enable_msix() Bjorn Helgaas
2014-03-13 15:28   ` Jens Axboe
2014-03-13 15:44     ` Bjorn Helgaas
2014-03-13 17:36     ` Alexander Gordeev [this message]
2014-03-13 17:39       ` Jens Axboe
2014-03-31 19:52       ` Alexander Gordeev
2014-03-31 20:12         ` Jens Axboe
2014-03-31 20:26           ` Alexander Gordeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140313173656.GA4939@dhcp-26-207.brq.redhat.com \
    --to=agordeev@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bhelgaas@google.com \
    --cc=iss_storagedev@hp.com \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mike.miller@hp.com \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).