From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Tim Harvey <tharvey@gateworks.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Jingoo Han <jg1.han@samsung.com>,
Lucas Stach <l.stach@pengutronix.de>,
Mark Rutland <mark.rutland@arm.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Richard Zhu <r65037@freescale.com>,
Sascha Hauer <kernel@pengutronix.de>,
Arnd Bergmann <arnd@arndb.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Simon Horman <horms@verge.net.au>,
Thierry Reding <thierry.reding@gmail.com>,
Ben Dooks <ben-linux@fluff.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Shawn Guo <shawn.guo@linaro.org>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [PATCH 1/2] ARM: DT: fix gic interrupt controller documentation
Date: Thu, 13 Mar 2014 12:25:54 -0600 [thread overview]
Message-ID: <20140313182554.GA15990@obsidianresearch.com> (raw)
In-Reply-To: <5321EE81.1030207@wwwdotorg.org>
On Thu, Mar 13, 2014 at 11:44:33AM -0600, Stephen Warren wrote:
> On 03/13/2014 11:40 AM, Tim Harvey wrote:
> > When using interrupt-maps, the size of a map entry is #address-cells +
> > #interrupt-cells for the parent interrupt controller. For the ARM GIC
> > address-cells should be 0 as this is not used.
> >
> > This patch fixes the example by correctly specifying #address-cells = 0.
>
> If the #address-cells property is required (well, or even optional...)
> in the node, shouldn't it be included in the list of required/optional
> properties above, and not solely included in the example?
AFAIK, #address-cells = 0 is the same as not including a
#address-cells at all.
Omitting entirely is what other interrupt-controller bindings are
doing, so I'd just drop mention of #address-cells completely.
Jason
next prev parent reply other threads:[~2014-03-13 18:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 17:40 [PATCH 0/2] ARM: IMX: fix ability to use pcie interrupt-map Tim Harvey
2014-03-13 17:40 ` [PATCH 1/2] ARM: DT: fix gic interrupt controller documentation Tim Harvey
2014-03-13 17:44 ` Stephen Warren
2014-03-13 18:25 ` Jason Gunthorpe [this message]
2014-03-13 22:25 ` Tim Harvey
2014-03-14 12:14 ` Shawn Guo
2014-03-14 13:05 ` Grant Likely
2014-03-13 17:40 ` [PATCH 2/2] ARM: dts: imx: fix invalid #address-cells value Tim Harvey
2014-03-14 13:31 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313182554.GA15990@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=bhelgaas@google.com \
--cc=grant.likely@linaro.org \
--cc=horms@verge.net.au \
--cc=jg1.han@samsung.com \
--cc=kernel@pengutronix.de \
--cc=kgene.kim@samsung.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=r65037@freescale.com \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=tharvey@gateworks.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).