Re: [PATCH 2/2] pci: added space before the open parenthesis

[Bjorn Helgaas <bhelgaas@google.com>]

On Fri, Apr 04, 2014 at 02:18:10PM -0400, Ryan Desfosses wrote:
> change made to resolve checkpatch.pl error
> 
> Signed-off-by: Ryan Desfosses <ryan@desfo.org>

Hi Ryan,

Thanks for this and your previous fix.  This "Signed-off-by" looks good.
Would you mind reposting the "pci_bus*" fix with a similar "Signed-off-by"?
It's a small fix, but strictly speaking, I need the "Signed-off-by" before
I can apply a patch.

We normally write the changelog so it can stand alone, i.e., you shouldn't
have to read the summary in addition to the changelog for it to make sense.
It might be useful to browse other changelogs, e.g., with "git log
--no-merges drivers/pci".  I do often fix capitalization, spelling, and
other errors because I think consistency makes it easier to read the
history.

The "[2/2]" notation suggests that there's another patch labeled "[1/2]"
(and probably an overall summary labeled "[0/2]"), and that all were posted
together.  In this case, I think you intended your "pci_bus*" patch to be
[1/2], but since they weren't posted together, it's a bit harder for me to
keep track of them as a group.

If you don't mind, I'll collect up this and your previous fix (and any
future ones you find) and squash them into a single "whitespace fixes" sort
of patch to reduce the number of commits for obviously-correct changes.

Thanks again, and welcome to Linux kernel development!

Oh, and I applied the patch below to my pending/misc branch (and I'll
update it with the other one when you post it).  I have a few other things
I hope to ask Linus to put in v3.15 yet, and I'll include this.

Bjorn



From: Ryan Desfosses <ryan@desfo.org>

PCI: Fix whitespace issues

Resolve whitespace issues that checkpatch.pl complained about.

No functional change.

Signed-off-by: Ryan Desfosses <ryan@desfo.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/pci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 7325d43bf030..1f0bf2eec127 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -114,7 +114,7 @@ unsigned char pci_bus_max_busnr(struct pci_bus* bus)
 	max = bus->busn_res.end;
 	list_for_each_entry(tmp, &bus->children, node) {
 		n = pci_bus_max_busnr(tmp);
-		if(n > max)
+		if (n > max)
 			max = n;
 	}
 	return max;