From: David Miller <davem@davemloft.net>
To: weiyang@linux.vnet.ibm.com
Cc: yevgenyp@mellanox.com, ogerlitz@mellanox.com, amirv@mellanox.com,
bhelgaas@google.com, linux-pci@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [Patch net-next] net/mlx4_core: match pci_device_id including dynids
Date: Mon, 07 Apr 2014 14:43:40 -0400 (EDT) [thread overview]
Message-ID: <20140407.144340.688537373203786487.davem@davemloft.net> (raw)
In-Reply-To: <1396750050-7183-1-git-send-email-weiyang@linux.vnet.ibm.com>
From: Wei Yang <weiyang@linux.vnet.ibm.com>
Date: Sun, 6 Apr 2014 10:07:30 +0800
> Fix issue introduced by commit: 97a5221 "net/mlx4_core: pass
> pci_device_id.driver_data to __mlx4_init_one during reset".
>
> pci_match_id() just match the static pci_device_id, which may return NULL if
> someone binds the driver to a device manually using
> /sys/bus/pci/drivers/.../new_id.
>
> This patch wrap up a helper function __mlx4_remove_one() which does the tear
> down function but preserve the drv_data. Functions like
> mlx4_pci_err_detected() and mlx4_restart_one() will call this one with out
> releasing drvdata.
>
> Tested on ConnectX-3.
>
> CC: Bjorn Helgaas <bhelgaas@google.com>
> CC: Amir Vadai <amirv@mellanox.com>
> Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
Please resubmit this when the net-next tree opens back up, thanks.
next prev parent reply other threads:[~2014-04-07 18:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-06 2:07 [Patch net-next] net/mlx4_core: match pci_device_id including dynids Wei Yang
2014-04-07 18:43 ` David Miller [this message]
2014-04-08 6:48 ` Or Gerlitz
2014-04-08 7:45 ` Wei Yang
2014-04-08 16:25 ` David Miller
2014-04-08 16:51 ` Or Gerlitz
2014-04-08 6:52 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407.144340.688537373203786487.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amirv@mellanox.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=weiyang@linux.vnet.ibm.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).