From: Bjorn Helgaas <bhelgaas@google.com>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 RESEND] portdrv: Use pci_enable_msix_exact() instead of pci_enable_msix()
Date: Thu, 24 Apr 2014 11:14:15 -0600 [thread overview]
Message-ID: <20140424171415.GB29593@google.com> (raw)
In-Reply-To: <1398092766-30078-1-git-send-email-agordeev@redhat.com>
On Mon, Apr 21, 2014 at 05:06:06PM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
Applied to pci/msi for v3.16, thanks!
> ---
> drivers/pci/pcie/portdrv_core.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
> index 986f8ea..0b1efb2 100644
> --- a/drivers/pci/pcie/portdrv_core.c
> +++ b/drivers/pci/pcie/portdrv_core.c
> @@ -99,7 +99,7 @@ static int pcie_port_enable_msix(struct pci_dev *dev, int *vectors, int mask)
> for (i = 0; i < nr_entries; i++)
> msix_entries[i].entry = i;
>
> - status = pci_enable_msix(dev, msix_entries, nr_entries);
> + status = pci_enable_msix_exact(dev, msix_entries, nr_entries);
> if (status)
> goto Exit;
>
> @@ -171,7 +171,7 @@ static int pcie_port_enable_msix(struct pci_dev *dev, int *vectors, int mask)
> pci_disable_msix(dev);
>
> /* Now allocate the MSI-X vectors for real */
> - status = pci_enable_msix(dev, msix_entries, nvec);
> + status = pci_enable_msix_exact(dev, msix_entries, nvec);
> if (status)
> goto Exit;
> }
> --
> 1.7.7.6
>
prev parent reply other threads:[~2014-04-24 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 15:06 [PATCH v2 RESEND] portdrv: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-04-24 17:14 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424171415.GB29593@google.com \
--to=bhelgaas@google.com \
--cc=agordeev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).