From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f51.google.com ([209.85.160.51]:46459 "EHLO mail-pb0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751706AbaDYRhX (ORCPT ); Fri, 25 Apr 2014 13:37:23 -0400 Received: by mail-pb0-f51.google.com with SMTP id uo5so3448900pbc.10 for ; Fri, 25 Apr 2014 10:37:22 -0700 (PDT) Date: Fri, 25 Apr 2014 11:37:18 -0600 From: Bjorn Helgaas To: Thomas Jarosch Cc: linux-pci@vger.kernel.org, Jesse Barnes , Daniel Vetter , Jani Nikula , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] PCI: Add new PCI id for Intel GPU interrupt quirk Message-ID: <20140425173718.GE32246@google.com> References: <3185796.STv3LRO1j8@storm> <20140425173521.GD32246@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20140425173521.GD32246@google.com> Sender: linux-pci-owner@vger.kernel.org List-ID: On Fri, Apr 25, 2014 at 11:35:21AM -0600, Bjorn Helgaas wrote: > [+cc Daniel, Jani, intel-gfx, dri-devel, -cc stable] > > On Mon, Apr 07, 2014 at 03:10:32PM +0200, Thomas Jarosch wrote: > > After a CPU upgrade while keeping the same mainboard, > > we faced "spurious interrupt" problems again. > > > > It turned out that the new CPU also featured a > > new GPU with a different PCI id. > > > > -> Add this PCI id to the quirk table. Probably all other > > Intel GPU PCI ids are affected, too, but I don't want > > to add them without a test system. > > Daniel, Jani, et al, do we need a better solution to this? Is there > a more general way to solve this than by tripping over affected machines > one-by-one? Could this be done in the driver rather than in a quirk? I guess it can't be done in the driver because the problem happens even if the driver isn't loaded, per f67fd55fa96f ("PCI: Add quirk for still enabled interrupts on Intel Sandy Bridge GPUs"). > > Signed-off-by: Thomas Jarosch > > Tested-by: Thomas Jarosch > > --- > > drivers/pci/quirks.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > > index e729206..0feb4a3 100644 > > --- a/drivers/pci/quirks.c > > +++ b/drivers/pci/quirks.c > > @@ -2954,6 +2954,7 @@ static void disable_igfx_irq(struct pci_dev *dev) > > } > > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0102, disable_igfx_irq); > > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x010a, disable_igfx_irq); > > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0152, disable_igfx_irq); > > > > /* > > * PCI devices which are on Intel chips can skip the 10ms delay > > -- > > 1.8.1.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html