From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
jg1.han@samsung.com, Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH v2] pci: pci-mvebu: Use '%pa' for printing 'phys_addr_t' type
Date: Tue, 29 Apr 2014 07:45:59 +0200 [thread overview]
Message-ID: <20140429074559.5c6970fd@skate> (raw)
In-Reply-To: <1398741896-5953-1-git-send-email-festevam@gmail.com>
Dear Fabio Estevam,
On Tue, 29 Apr 2014 00:24:56 -0300, Fabio Estevam wrote:
> if (ret) {
> dev_err(&port->pcie->pdev->dev,
> - "Could not create MBus window at 0x%x, size 0x%x: %d\n",
> - base, sz, ret);
> + "Could not create MBus window at [mem %pa - %pa] :%d\n",
> + &base, &base + sz, ret);
Are you sure '&base + sz' works here? %pa needs a reference as
argument, so &base looks good. But '&base + sz' means you will print
the value which is at the address of base, to which 'sz' is added,
which is not what we want here. Probably you need something like:
phys_addr_t end = base + sz;
and then use '&end'.
Or I am missing something?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-29 5:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 3:24 [PATCH v2] pci: pci-mvebu: Use '%pa' for printing 'phys_addr_t' type Fabio Estevam
2014-04-29 5:35 ` Jingoo Han
2014-04-29 5:45 ` Thomas Petazzoni [this message]
2014-04-29 5:53 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429074559.5c6970fd@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).