From: Will Deacon <will.deacon@arm.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"sthokal@xilinx.com" <sthokal@xilinx.com>,
"jgunthorpe@obsidianresearch.com"
<jgunthorpe@obsidianresearch.com>,
"bhelgaas@google.com" <bhelgaas@google.com>
Subject: Re: [PATCH v6 1/3] ARM: kconfig: allow PCI support to be selected with ARCH_MULTIPLATFORM
Date: Thu, 8 May 2014 16:15:27 +0100 [thread overview]
Message-ID: <20140508151526.GE8981@arm.com> (raw)
In-Reply-To: <536B9DE9.80100@wwwdotorg.org>
On Thu, May 08, 2014 at 04:08:25PM +0100, Stephen Warren wrote:
> On 05/07/2014 10:07 AM, Will Deacon wrote:
> > When targetting ARCH_MULTIPLATFORM, we may include support for SoCs with
> > PCI-capable devices (e.g. mach-virt with virtio-pci).
> >
> > This patch allows PCI support to be selected for these SoCs by selecting
> > CONFIG_MIGHT_HAVE_PCI when CONFIG_ARCH_MULTIPLATFORM=y.
>
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>
> > @@ -314,6 +314,7 @@ config ARCH_MULTIPLATFORM
> > select CLKSRC_OF
> > select COMMON_CLK
> > select GENERIC_CLOCKEVENTS
> > + select MIGHT_HAVE_PCI
>
> Doesn't ARCH_MULTIPLATFORM allow ARCH_$soc to be selected, and ARCH_$soc
> selects MIGHT_HAVE_PCI?
>
> That way, you can only enable PCI support if you have actually enabled
> an SoC that has PCI, and equally ARCH_$soc selects MIGHT_HAVE_PCI just
> like it always used to work before ARCH_MULTIPLATFORM.
Yeah, I initially had this only for mach-virt, but the last review suggested
moving it here:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-May/252937.html
Will
next prev parent reply other threads:[~2014-05-08 15:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 16:07 [PATCH v6 0/3] Support for Generic PCI Host Controller Will Deacon
2014-05-07 16:07 ` [PATCH v6 1/3] ARM: kconfig: allow PCI support to be selected with ARCH_MULTIPLATFORM Will Deacon
2014-05-08 15:08 ` Stephen Warren
2014-05-08 15:15 ` Will Deacon [this message]
2014-05-08 15:38 ` Stephen Warren
2014-05-14 14:01 ` Rob Herring
2014-05-15 12:39 ` Will Deacon
2014-05-15 13:16 ` Rob Herring
2014-05-15 13:32 ` Arnd Bergmann
2014-05-07 16:07 ` [PATCH v6 2/3] PCI: ARM: add support for generic PCI host controller Will Deacon
2014-05-07 16:07 ` [PATCH v6 3/3] MAINTAINERS: add entry for generic PCI host controller driver Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508151526.GE8981@arm.com \
--to=will.deacon@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=sthokal@xilinx.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).