* [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()
@ 2014-05-13 15:01 Alexander Gordeev
2014-05-13 15:20 ` Alexander Gordeev
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Alexander Gordeev @ 2014-05-13 15:01 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-kernel, Alexander Gordeev, Matt Porter, Alexandre Bounine,
linux-pci
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Matt Porter <mporter@kernel.crashing.org>
Cc: Alexandre Bounine <alexandre.bounine@idt.com>
Cc: linux-pci@vger.kernel.org
---
drivers/rapidio/devices/tsi721.c | 11 +++--------
1 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/rapidio/devices/tsi721.c b/drivers/rapidio/devices/tsi721.c
index 1753dc6..2ca1a0b 100644
--- a/drivers/rapidio/devices/tsi721.c
+++ b/drivers/rapidio/devices/tsi721.c
@@ -768,15 +768,10 @@ static int tsi721_enable_msix(struct tsi721_device *priv)
}
#endif /* CONFIG_RAPIDIO_DMA_ENGINE */
- err = pci_enable_msix(priv->pdev, entries, ARRAY_SIZE(entries));
+ err = pci_enable_msix_exact(priv->pdev, entries, ARRAY_SIZE(entries));
if (err) {
- if (err > 0)
- dev_info(&priv->pdev->dev,
- "Only %d MSI-X vectors available, "
- "not using MSI-X\n", err);
- else
- dev_err(&priv->pdev->dev,
- "Failed to enable MSI-X (err=%d)\n", err);
+ dev_err(&priv->pdev->dev,
+ "Failed to enable MSI-X (err=%d)\n", err);
return err;
}
--
1.7.7.6
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-05-13 15:01 [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
@ 2014-05-13 15:20 ` Alexander Gordeev
2014-05-13 21:46 ` Andrew Morton
2014-05-27 23:19 ` Bjorn Helgaas
2 siblings, 0 replies; 6+ messages in thread
From: Alexander Gordeev @ 2014-05-13 15:20 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Matt Porter, Alexandre Bounine, linux-pci
On Tue, May 13, 2014 at 05:01:32PM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Matt Porter <mporter@kernel.crashing.org>
> Cc: Alexandre Bounine <alexandre.bounine@idt.com>
I forgot to note this patch has also been
Acked-by: Alexandre Bounine <alexandre.bounine@idt.com>
> Cc: linux-pci@vger.kernel.org
> ---
> drivers/rapidio/devices/tsi721.c | 11 +++--------
> 1 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/rapidio/devices/tsi721.c b/drivers/rapidio/devices/tsi721.c
> index 1753dc6..2ca1a0b 100644
> --- a/drivers/rapidio/devices/tsi721.c
> +++ b/drivers/rapidio/devices/tsi721.c
> @@ -768,15 +768,10 @@ static int tsi721_enable_msix(struct tsi721_device *priv)
> }
> #endif /* CONFIG_RAPIDIO_DMA_ENGINE */
>
> - err = pci_enable_msix(priv->pdev, entries, ARRAY_SIZE(entries));
> + err = pci_enable_msix_exact(priv->pdev, entries, ARRAY_SIZE(entries));
> if (err) {
> - if (err > 0)
> - dev_info(&priv->pdev->dev,
> - "Only %d MSI-X vectors available, "
> - "not using MSI-X\n", err);
> - else
> - dev_err(&priv->pdev->dev,
> - "Failed to enable MSI-X (err=%d)\n", err);
> + dev_err(&priv->pdev->dev,
> + "Failed to enable MSI-X (err=%d)\n", err);
> return err;
> }
>
> --
> 1.7.7.6
>
--
Regards,
Alexander Gordeev
agordeev@redhat.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-05-13 15:01 [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-05-13 15:20 ` Alexander Gordeev
@ 2014-05-13 21:46 ` Andrew Morton
2014-05-14 4:54 ` Alexander Gordeev
2014-05-27 23:19 ` Bjorn Helgaas
2 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2014-05-13 21:46 UTC (permalink / raw)
To: Alexander Gordeev; +Cc: linux-kernel, Matt Porter, Alexandre Bounine, linux-pci
On Tue, 13 May 2014 17:01:32 +0200 Alexander Gordeev <agordeev@redhat.com> wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
What (if any) runtime effect does this patch have?
> --- a/drivers/rapidio/devices/tsi721.c
> +++ b/drivers/rapidio/devices/tsi721.c
> @@ -768,15 +768,10 @@ static int tsi721_enable_msix(struct tsi721_device *priv)
> }
> #endif /* CONFIG_RAPIDIO_DMA_ENGINE */
>
> - err = pci_enable_msix(priv->pdev, entries, ARRAY_SIZE(entries));
> + err = pci_enable_msix_exact(priv->pdev, entries, ARRAY_SIZE(entries));
> if (err) {
> - if (err > 0)
> - dev_info(&priv->pdev->dev,
> - "Only %d MSI-X vectors available, "
> - "not using MSI-X\n", err);
> - else
> - dev_err(&priv->pdev->dev,
> - "Failed to enable MSI-X (err=%d)\n", err);
> + dev_err(&priv->pdev->dev,
> + "Failed to enable MSI-X (err=%d)\n", err);
> return err;
> }
>
> --
> 1.7.7.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-05-13 21:46 ` Andrew Morton
@ 2014-05-14 4:54 ` Alexander Gordeev
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Gordeev @ 2014-05-14 4:54 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Matt Porter, Alexandre Bounine, linux-pci
On Tue, May 13, 2014 at 02:46:34PM -0700, Andrew Morton wrote:
> On Tue, 13 May 2014 17:01:32 +0200 Alexander Gordeev <agordeev@redhat.com> wrote:
>
> > As result of deprecation of MSI-X/MSI enablement functions
> > pci_enable_msix() and pci_enable_msi_block() all drivers
> > using these two interfaces need to be updated to use the
> > new pci_enable_msi_range() or pci_enable_msi_exact()
> > and pci_enable_msix_range() or pci_enable_msix_exact()
> > interfaces.
> >
>
> What (if any) runtime effect does this patch have?
None.
--
Regards,
Alexander Gordeev
agordeev@redhat.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-05-13 15:01 [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-05-13 15:20 ` Alexander Gordeev
2014-05-13 21:46 ` Andrew Morton
@ 2014-05-27 23:19 ` Bjorn Helgaas
2014-05-28 8:57 ` Alexander Gordeev
2 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2014-05-27 23:19 UTC (permalink / raw)
To: Alexander Gordeev
Cc: Andrew Morton, linux-kernel, Matt Porter, Alexandre Bounine,
linux-pci
On Tue, May 13, 2014 at 05:01:32PM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Matt Porter <mporter@kernel.crashing.org>
> Cc: Alexandre Bounine <alexandre.bounine@idt.com>
> Cc: linux-pci@vger.kernel.org
I assume this is being handled by Matt and/or Alexandre (listed in
MAINTAINERS). Let me know if I should do anything.
> ---
> drivers/rapidio/devices/tsi721.c | 11 +++--------
> 1 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/rapidio/devices/tsi721.c b/drivers/rapidio/devices/tsi721.c
> index 1753dc6..2ca1a0b 100644
> --- a/drivers/rapidio/devices/tsi721.c
> +++ b/drivers/rapidio/devices/tsi721.c
> @@ -768,15 +768,10 @@ static int tsi721_enable_msix(struct tsi721_device *priv)
> }
> #endif /* CONFIG_RAPIDIO_DMA_ENGINE */
>
> - err = pci_enable_msix(priv->pdev, entries, ARRAY_SIZE(entries));
> + err = pci_enable_msix_exact(priv->pdev, entries, ARRAY_SIZE(entries));
> if (err) {
> - if (err > 0)
> - dev_info(&priv->pdev->dev,
> - "Only %d MSI-X vectors available, "
> - "not using MSI-X\n", err);
> - else
> - dev_err(&priv->pdev->dev,
> - "Failed to enable MSI-X (err=%d)\n", err);
> + dev_err(&priv->pdev->dev,
> + "Failed to enable MSI-X (err=%d)\n", err);
> return err;
> }
>
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-05-27 23:19 ` Bjorn Helgaas
@ 2014-05-28 8:57 ` Alexander Gordeev
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Gordeev @ 2014-05-28 8:57 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Andrew Morton, linux-kernel, Matt Porter, Alexandre Bounine,
linux-pci
On Tue, May 27, 2014 at 05:19:50PM -0600, Bjorn Helgaas wrote:
> I assume this is being handled by Matt and/or Alexandre (listed in
> MAINTAINERS). Let me know if I should do anything.
Hi Bjorn,
No worries, the patch is in Andrew's tree already.
--
Regards,
Alexander Gordeev
agordeev@redhat.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-28 8:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-13 15:01 [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-05-13 15:20 ` Alexander Gordeev
2014-05-13 21:46 ` Andrew Morton
2014-05-14 4:54 ` Alexander Gordeev
2014-05-27 23:19 ` Bjorn Helgaas
2014-05-28 8:57 ` Alexander Gordeev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).