From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f171.google.com ([209.85.223.171]:39089 "EHLO mail-ie0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186AbaE0XTy (ORCPT ); Tue, 27 May 2014 19:19:54 -0400 Received: by mail-ie0-f171.google.com with SMTP id to1so9610042ieb.30 for ; Tue, 27 May 2014 16:19:53 -0700 (PDT) Date: Tue, 27 May 2014 17:19:50 -0600 From: Bjorn Helgaas To: Alexander Gordeev Cc: Andrew Morton , linux-kernel@vger.kernel.org, Matt Porter , Alexandre Bounine , linux-pci@vger.kernel.org Subject: Re: [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix() Message-ID: <20140527231950.GI11907@google.com> References: <1399993292-31692-1-git-send-email-agordeev@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1399993292-31692-1-git-send-email-agordeev@redhat.com> Sender: linux-pci-owner@vger.kernel.org List-ID: On Tue, May 13, 2014 at 05:01:32PM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. > > Signed-off-by: Alexander Gordeev > Cc: Matt Porter > Cc: Alexandre Bounine > Cc: linux-pci@vger.kernel.org I assume this is being handled by Matt and/or Alexandre (listed in MAINTAINERS). Let me know if I should do anything. > --- > drivers/rapidio/devices/tsi721.c | 11 +++-------- > 1 files changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/rapidio/devices/tsi721.c b/drivers/rapidio/devices/tsi721.c > index 1753dc6..2ca1a0b 100644 > --- a/drivers/rapidio/devices/tsi721.c > +++ b/drivers/rapidio/devices/tsi721.c > @@ -768,15 +768,10 @@ static int tsi721_enable_msix(struct tsi721_device *priv) > } > #endif /* CONFIG_RAPIDIO_DMA_ENGINE */ > > - err = pci_enable_msix(priv->pdev, entries, ARRAY_SIZE(entries)); > + err = pci_enable_msix_exact(priv->pdev, entries, ARRAY_SIZE(entries)); > if (err) { > - if (err > 0) > - dev_info(&priv->pdev->dev, > - "Only %d MSI-X vectors available, " > - "not using MSI-X\n", err); > - else > - dev_err(&priv->pdev->dev, > - "Failed to enable MSI-X (err=%d)\n", err); > + dev_err(&priv->pdev->dev, > + "Failed to enable MSI-X (err=%d)\n", err); > return err; > } > > -- > 1.7.7.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html