From: Bjorn Helgaas <bhelgaas@google.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-pci@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
jg1.han@samsung.com
Subject: Re: [PATCH 1/1] PCI: exynos: Fix section mismatch warning
Date: Thu, 29 May 2014 16:19:24 -0600 [thread overview]
Message-ID: <20140529221924.GA11907@google.com> (raw)
In-Reply-To: <1401270525-27139-1-git-send-email-sachin.kamat@linaro.org>
On Wed, May 28, 2014 at 03:18:45PM +0530, Sachin Kamat wrote:
> add_pcie_port is called from probe which is annotated with __init.
> add_pcie_port calls dw_pcie_host_init which is also annotated with
> __init. Thus it makes sense to annotate add_pcie_port with __init
> to avoid the following section mismatch warning:
>
> WARNING: drivers/pci/built-in.o(.text.unlikely+0xf8): Section mismatch in reference from the function add_pcie_port() to the function .init.text:dw_pcie_host_init()
> The function add_pcie_port() references
> the function __init dw_pcie_host_init().
> This is often because add_pcie_port lacks a __init
> annotation or the annotation of dw_pcie_host_init is wrong.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied with Jingoo's ack to pci/host-exynos for v3.16, thanks!
> ---
> drivers/pci/host/pci-exynos.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c
> index 3de6bfbbe8e9..3c1ff89829ec 100644
> --- a/drivers/pci/host/pci-exynos.c
> +++ b/drivers/pci/host/pci-exynos.c
> @@ -511,7 +511,8 @@ static struct pcie_host_ops exynos_pcie_host_ops = {
> .host_init = exynos_pcie_host_init,
> };
>
> -static int add_pcie_port(struct pcie_port *pp, struct platform_device *pdev)
> +static int __init add_pcie_port(struct pcie_port *pp,
> + struct platform_device *pdev)
> {
> int ret;
>
> --
> 1.7.9.5
>
prev parent reply other threads:[~2014-05-29 22:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 9:48 [PATCH 1/1] PCI: exynos: Fix section mismatch warning Sachin Kamat
2014-05-29 6:08 ` Jingoo Han
2014-05-29 22:19 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140529221924.GA11907@google.com \
--to=bhelgaas@google.com \
--cc=jg1.han@samsung.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).