From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f179.google.com ([209.85.213.179]:45135 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933743AbaE3Po6 (ORCPT ); Fri, 30 May 2014 11:44:58 -0400 Received: by mail-ig0-f179.google.com with SMTP id hn18so978141igb.12 for ; Fri, 30 May 2014 08:44:57 -0700 (PDT) Date: Fri, 30 May 2014 09:44:55 -0600 From: Bjorn Helgaas To: Murali Karicheri Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , Arnd Bergmann , Jason Gunthorpe , Santosh Shilimkar Subject: Re: [PATCH v1] ARM: pci: add call to pcie_bus_configure_settings() Message-ID: <20140530154455.GC4607@google.com> References: <1401297293-3950-1-git-send-email-m-karicheri2@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1401297293-3950-1-git-send-email-m-karicheri2@ti.com> Sender: linux-pci-owner@vger.kernel.org List-ID: On Wed, May 28, 2014 at 01:14:53PM -0400, Murali Karicheri wrote: > Call pcie_bus_configure_settings on ARM, like for other platforms. > pcie_bus_configure_settings makes sure the MPS across the bus is > uniform and provides the ability to tune the MRSS and MPS to higher > performance values. This is particularly important for embedded where > there is no firmware to program these PCI-E settings for the OS. > > Signed-off-by: Murali Karicheri I applied this to pci/misc for v3.16. Russell, let me know if you object or prefer another route, and I can drop it. I tweaked the changelog but didn't touch the actual patch, so I think git will do the right thing if it arrives via two trees. > CC: Russell King > CC: Bjorn Helgaas > CC: Arnd Bergmann > CC: Jason Gunthorpe > CC: Santosh Shilimkar > --- > - Fixed comments against initial version > arch/arm/kernel/bios32.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c > index 16d43cd..17a26c1 100644 > --- a/arch/arm/kernel/bios32.c > +++ b/arch/arm/kernel/bios32.c > @@ -545,6 +545,18 @@ void pci_common_init_dev(struct device *parent, struct hw_pci *hw) > */ > pci_bus_add_devices(bus); > } > + > + list_for_each_entry(sys, &head, node) { > + struct pci_bus *bus = sys->bus; > + > + /* Configure PCI Express settings */ > + if (bus && !pci_has_flag(PCI_PROBE_ONLY)) { > + struct pci_bus *child; > + > + list_for_each_entry(child, &bus->children, node) > + pcie_bus_configure_settings(child); > + } > + } > } > > #ifndef CONFIG_PCI_HOST_ITE8152 > -- > 1.7.9.5 >