From: Bjorn Helgaas <bhelgaas@google.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-pci@vger.kernel.org, r65037@freescale.com,
shawn.guo@linaro.org, Sean Cross <xobs@kosagi.com>
Subject: Re: [PATCH 1/1] PCI: imx6: Annotate imx6_add_pcie_port with __init
Date: Fri, 30 May 2014 09:53:14 -0600 [thread overview]
Message-ID: <20140530155314.GD4607@google.com> (raw)
In-Reply-To: <1401431928-15096-1-git-send-email-sachin.kamat@linaro.org>
On Fri, May 30, 2014 at 12:08:48PM +0530, Sachin Kamat wrote:
> imx6_add_pcie_port is called from probe which is annotated with __init.
> imx6_add_pcie_port calls dw_pcie_host_init which is also annotated with
> __init. Thus it makes sense to annotate imx6_add_pcie_port with __init.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Sean Cross <xobs@kosagi.com>
This looks correct to me, so I put it on a pci/host-imx6 branch to squeeze
it in for v3.16. Richard, Shawn, let me know (soonish, since the merge
window may open next week) if you object.
> ---
> drivers/pci/host/pci-imx6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
> index ee082509b0ba..facbf8faa353 100644
> --- a/drivers/pci/host/pci-imx6.c
> +++ b/drivers/pci/host/pci-imx6.c
> @@ -487,7 +487,7 @@ static struct pcie_host_ops imx6_pcie_host_ops = {
> .host_init = imx6_pcie_host_init,
> };
>
> -static int imx6_add_pcie_port(struct pcie_port *pp,
> +static int __init imx6_add_pcie_port(struct pcie_port *pp,
> struct platform_device *pdev)
> {
> int ret;
> --
> 1.7.9.5
>
prev parent reply other threads:[~2014-05-30 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 6:38 [PATCH 1/1] PCI: imx6: Annotate imx6_add_pcie_port with __init Sachin Kamat
2014-05-30 15:53 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530155314.GD4607@google.com \
--to=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=r65037@freescale.com \
--cc=sachin.kamat@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=xobs@kosagi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).