From: Bjorn Helgaas <bhelgaas@google.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: exynos: Add exynos prefix before add_pcie_port/pcie_init
Date: Tue, 17 Jun 2014 16:05:38 -0600 [thread overview]
Message-ID: <20140617220538.GB30559@google.com> (raw)
In-Reply-To: <000601cf7f30$31b53270$951f9750$%han@samsung.com>
On Tue, Jun 03, 2014 at 10:31:58PM +0900, Jingoo Han wrote:
> The add_pcie_port/pcie_init functions are Exynos-specific.
> Add exynos prefix to avoid collision in global name space.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied to pci/host-exynos for v3.17, thanks!
> ---
> drivers/pci/host/pci-exynos.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c
> index 1632661..2f59851 100644
> --- a/drivers/pci/host/pci-exynos.c
> +++ b/drivers/pci/host/pci-exynos.c
> @@ -509,8 +509,8 @@ static struct pcie_host_ops exynos_pcie_host_ops = {
> .host_init = exynos_pcie_host_init,
> };
>
> -static int __init add_pcie_port(struct pcie_port *pp,
> - struct platform_device *pdev)
> +static int __init exynos_add_pcie_port(struct pcie_port *pp,
> + struct platform_device *pdev)
> {
> int ret;
>
> @@ -616,7 +616,7 @@ static int __init exynos_pcie_probe(struct platform_device *pdev)
> goto fail_bus_clk;
> }
>
> - ret = add_pcie_port(pp, pdev);
> + ret = exynos_add_pcie_port(pp, pdev);
> if (ret < 0)
> goto fail_bus_clk;
>
> @@ -657,11 +657,11 @@ static struct platform_driver exynos_pcie_driver = {
>
> /* Exynos PCIe driver does not allow module unload */
>
> -static int __init pcie_init(void)
> +static int __init exynos_pcie_init(void)
> {
> return platform_driver_probe(&exynos_pcie_driver, exynos_pcie_probe);
> }
> -subsys_initcall(pcie_init);
> +subsys_initcall(exynos_pcie_init);
>
> MODULE_AUTHOR("Jingoo Han <jg1.han@samsung.com>");
> MODULE_DESCRIPTION("Samsung PCIe host controller driver");
> --
> 1.7.10.4
>
>
next prev parent reply other threads:[~2014-06-17 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 13:31 [PATCH] PCI: exynos: Add exynos prefix before add_pcie_port/pcie_init Jingoo Han
2014-06-17 22:05 ` Bjorn Helgaas [this message]
2014-08-27 4:37 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617220538.GB30559@google.com \
--to=bhelgaas@google.com \
--cc=jg1.han@samsung.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).