From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: lenb@kernel.org, robert.moore@intel.com, lv.zheng@intel.com,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, bhelgaas@google.com
Subject: Re: [PATCH 1/4] ACPI: Support _OSI("Darwin") correctly
Date: Wed, 18 Jun 2014 06:26:15 +0100 [thread overview]
Message-ID: <20140618052615.GA26873@srcf.ucam.org> (raw)
In-Reply-To: <20140617144614.GA16934@srcf.ucam.org>
On Tue, Jun 17, 2014 at 03:46:15PM +0100, Matthew Garrett wrote:
> On Tue, Jun 17, 2014 at 02:11:36PM +0200, Rafael J. Wysocki wrote:
> > Does applying this patch without the rest of the series makes things worse
> > or better on the machines in question (or perhaps it doesn't matter at all
> > alone)?
>
> On its own, I think this will do nothing.
Ugh, no, sorry - on its own, this will break PCIe hotplug events and
battery reporting. It should only be merged with the others.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2014-06-18 5:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 16:33 ACPI: Improve behaviour on Apple hardware Matthew Garrett
2014-06-01 16:33 ` [PATCH 1/4] ACPI: Support _OSI("Darwin") correctly Matthew Garrett
2014-06-17 12:11 ` Rafael J. Wysocki
2014-06-17 14:46 ` Matthew Garrett
2014-06-18 5:26 ` Matthew Garrett [this message]
2014-06-18 23:42 ` Rafael J. Wysocki
2014-06-01 16:33 ` [PATCH 2/4] ACPI: Don't call PCI OSC on Apple hardware when claiming to be Darwin Matthew Garrett
2014-06-01 16:33 ` [PATCH 3/4] ACPI: Don't assume the existence of an SBS charger Matthew Garrett
2014-06-01 16:33 ` [PATCH 4/4] ACPI: Disable smart battery manager on Apple Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618052615.GA26873@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).