From: Bjorn Helgaas <bhelgaas@google.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, Ryan Desfosses <ryan@desfo.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers/pci/hotplug/cpqphp_sysfs.c: remove unnecessary null test before debugfs_remove
Date: Sat, 5 Jul 2014 11:52:16 -0600 [thread overview]
Message-ID: <20140705175216.GE26618@google.com> (raw)
In-Reply-To: <1403948683-10410-1-git-send-email-fabf@skynet.be>
On Sat, Jun 28, 2014 at 11:44:43AM +0200, Fabian Frederick wrote:
> Fix checkpatch warning:
> "WARNING: debugfs_remove(NULL) is safe this check is probably not required"
>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Ryan Desfosses <ryan@desfo.org>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Applied to pci/hotplug for v3.17, thanks!
> ---
> drivers/pci/hotplug/cpqphp_sysfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/hotplug/cpqphp_sysfs.c b/drivers/pci/hotplug/cpqphp_sysfs.c
> index 4a392c4..d81648f 100644
> --- a/drivers/pci/hotplug/cpqphp_sysfs.c
> +++ b/drivers/pci/hotplug/cpqphp_sysfs.c
> @@ -216,8 +216,7 @@ void cpqhp_create_debugfs_files(struct controller *ctrl)
>
> void cpqhp_remove_debugfs_files(struct controller *ctrl)
> {
> - if (ctrl->dentry)
> - debugfs_remove(ctrl->dentry);
> + debugfs_remove(ctrl->dentry);
> ctrl->dentry = NULL;
> }
>
> --
> 1.8.4.5
>
prev parent reply other threads:[~2014-07-05 17:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 9:44 [PATCH 1/1] drivers/pci/hotplug/cpqphp_sysfs.c: remove unnecessary null test before debugfs_remove Fabian Frederick
2014-07-05 17:52 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140705175216.GE26618@google.com \
--to=bhelgaas@google.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ryan@desfo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).