* [PATCH 1/1] drivers/pci/hotplug/cpqphp_sysfs.c: remove unnecessary null test before debugfs_remove
@ 2014-06-28 9:44 Fabian Frederick
2014-07-05 17:52 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-06-28 9:44 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Bjorn Helgaas, Ryan Desfosses, linux-pci
Fix checkpatch warning:
"WARNING: debugfs_remove(NULL) is safe this check is probably not required"
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Ryan Desfosses <ryan@desfo.org>
Cc: linux-pci@vger.kernel.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/pci/hotplug/cpqphp_sysfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pci/hotplug/cpqphp_sysfs.c b/drivers/pci/hotplug/cpqphp_sysfs.c
index 4a392c4..d81648f 100644
--- a/drivers/pci/hotplug/cpqphp_sysfs.c
+++ b/drivers/pci/hotplug/cpqphp_sysfs.c
@@ -216,8 +216,7 @@ void cpqhp_create_debugfs_files(struct controller *ctrl)
void cpqhp_remove_debugfs_files(struct controller *ctrl)
{
- if (ctrl->dentry)
- debugfs_remove(ctrl->dentry);
+ debugfs_remove(ctrl->dentry);
ctrl->dentry = NULL;
}
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] drivers/pci/hotplug/cpqphp_sysfs.c: remove unnecessary null test before debugfs_remove
2014-06-28 9:44 [PATCH 1/1] drivers/pci/hotplug/cpqphp_sysfs.c: remove unnecessary null test before debugfs_remove Fabian Frederick
@ 2014-07-05 17:52 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2014-07-05 17:52 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, Ryan Desfosses, linux-pci
On Sat, Jun 28, 2014 at 11:44:43AM +0200, Fabian Frederick wrote:
> Fix checkpatch warning:
> "WARNING: debugfs_remove(NULL) is safe this check is probably not required"
>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Ryan Desfosses <ryan@desfo.org>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Applied to pci/hotplug for v3.17, thanks!
> ---
> drivers/pci/hotplug/cpqphp_sysfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/hotplug/cpqphp_sysfs.c b/drivers/pci/hotplug/cpqphp_sysfs.c
> index 4a392c4..d81648f 100644
> --- a/drivers/pci/hotplug/cpqphp_sysfs.c
> +++ b/drivers/pci/hotplug/cpqphp_sysfs.c
> @@ -216,8 +216,7 @@ void cpqhp_create_debugfs_files(struct controller *ctrl)
>
> void cpqhp_remove_debugfs_files(struct controller *ctrl)
> {
> - if (ctrl->dentry)
> - debugfs_remove(ctrl->dentry);
> + debugfs_remove(ctrl->dentry);
> ctrl->dentry = NULL;
> }
>
> --
> 1.8.4.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-05 17:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-28 9:44 [PATCH 1/1] drivers/pci/hotplug/cpqphp_sysfs.c: remove unnecessary null test before debugfs_remove Fabian Frederick
2014-07-05 17:52 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).