From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 10 Jul 2014 16:02:33 -0600 From: Bjorn Helgaas To: Rasmus Villemoes Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pci: Add include guard to include/linux/pci_ids.h Message-ID: <20140710220233.GA21053@google.com> References: <1404993911-10544-1-git-send-email-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1404993911-10544-1-git-send-email-linux@rasmusvillemoes.dk> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Thu, Jul 10, 2014 at 02:05:11PM +0200, Rasmus Villemoes wrote: > Adding an include guard frees the preprocessor from reparsing over > 2600 #defines in the cases where pci_ids.h is somehow included more > than once. This gives a tiny-but-measurable performance improvement > when compiling such files. > > Signed-off-by: Rasmus Villemoes Applied to pci/misc for v3.17, thanks! > --- > include/linux/pci_ids.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index 7fa3173..6ed0bb7 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -6,6 +6,8 @@ > * Do not add new entries to this file unless the definitions > * are shared between multiple drivers. > */ > +#ifndef _LINUX_PCI_IDS_H > +#define _LINUX_PCI_IDS_H > > /* Device classes and subclasses */ > > @@ -2968,3 +2970,5 @@ > #define PCI_DEVICE_ID_XEN_PLATFORM 0x0001 > > #define PCI_VENDOR_ID_OCZ 0x1b85 > + > +#endif /* _LINUX_PCI_IDS_H */ > -- > 1.9.2 >