* [PATCH] PCI/AER: Forward declare struct pci_dev to avoid warning
@ 2014-07-21 16:30 Tuomas Tynkkynen
2014-07-21 23:27 ` Gavin Shan
0 siblings, 1 reply; 3+ messages in thread
From: Tuomas Tynkkynen @ 2014-07-21 16:30 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, linux-kernel, Tuomas Tynkkynen
Forward declaring struct pci_dev in aer.h avoids this warning:
In file included from include/ras/ras_event.h:11:0,
from drivers/ras/ras.c:13:
include/linux/aer.h:38:44: warning: 'struct pci_dev’ declared inside parameter list [enabled by default]
include/linux/aer.h:38:44: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
Signed-off-by: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
---
include/linux/aer.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/aer.h b/include/linux/aer.h
index 4dbaa70..d9ec8dd 100644
--- a/include/linux/aer.h
+++ b/include/linux/aer.h
@@ -7,6 +7,8 @@
#ifndef _AER_H_
#define _AER_H_
+struct pci_dev;
+
#define AER_NONFATAL 0
#define AER_FATAL 1
#define AER_CORRECTABLE 2
--
1.8.1.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PCI/AER: Forward declare struct pci_dev to avoid warning
2014-07-21 16:30 [PATCH] PCI/AER: Forward declare struct pci_dev to avoid warning Tuomas Tynkkynen
@ 2014-07-21 23:27 ` Gavin Shan
2014-07-22 0:00 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Gavin Shan @ 2014-07-21 23:27 UTC (permalink / raw)
To: Tuomas Tynkkynen; +Cc: Bjorn Helgaas, linux-pci, linux-kernel
On Mon, Jul 21, 2014 at 07:30:43PM +0300, Tuomas Tynkkynen wrote:
I guess it's same issue and fix as:
http://patchwork.ozlabs.org/patch/370629/
Thanks,
Gavin
>Forward declaring struct pci_dev in aer.h avoids this warning:
>
>In file included from include/ras/ras_event.h:11:0,
> from drivers/ras/ras.c:13:
>include/linux/aer.h:38:44: warning: 'struct pci_dev’ declared inside parameter list [enabled by default]
>include/linux/aer.h:38:44: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>
>Signed-off-by: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
>---
> include/linux/aer.h | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/include/linux/aer.h b/include/linux/aer.h
>index 4dbaa70..d9ec8dd 100644
>--- a/include/linux/aer.h
>+++ b/include/linux/aer.h
>@@ -7,6 +7,8 @@
> #ifndef _AER_H_
> #define _AER_H_
>
>+struct pci_dev;
>+
> #define AER_NONFATAL 0
> #define AER_FATAL 1
> #define AER_CORRECTABLE 2
>--
>1.8.1.5
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-pci" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI/AER: Forward declare struct pci_dev to avoid warning
2014-07-21 23:27 ` Gavin Shan
@ 2014-07-22 0:00 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2014-07-22 0:00 UTC (permalink / raw)
To: Gavin Shan, Tuomas Tynkkynen; +Cc: Bjorn Helgaas, linux-pci, linux-kernel
On 07/21/2014 04:27 PM, Gavin Shan wrote:
> On Mon, Jul 21, 2014 at 07:30:43PM +0300, Tuomas Tynkkynen wrote:
>
> I guess it's same issue and fix as:
>
> http://patchwork.ozlabs.org/patch/370629/
Yes, and it still needs to be merged.... :(
> Thanks,
> Gavin
>
>> Forward declaring struct pci_dev in aer.h avoids this warning:
>>
>> In file included from include/ras/ras_event.h:11:0,
>> from drivers/ras/ras.c:13:
>> include/linux/aer.h:38:44: warning: 'struct pci_dev’ declared inside parameter list [enabled by default]
>> include/linux/aer.h:38:44: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>>
>> Signed-off-by: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
>> ---
>> include/linux/aer.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/include/linux/aer.h b/include/linux/aer.h
>> index 4dbaa70..d9ec8dd 100644
>> --- a/include/linux/aer.h
>> +++ b/include/linux/aer.h
>> @@ -7,6 +7,8 @@
>> #ifndef _AER_H_
>> #define _AER_H_
>>
>> +struct pci_dev;
>> +
>> #define AER_NONFATAL 0
>> #define AER_FATAL 1
>> #define AER_CORRECTABLE 2
>> --
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-22 0:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-21 16:30 [PATCH] PCI/AER: Forward declare struct pci_dev to avoid warning Tuomas Tynkkynen
2014-07-21 23:27 ` Gavin Shan
2014-07-22 0:00 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).