* [PATCH 0/3] Fixing checkpatch errors and warnings for PCI hotplug
@ 2014-08-04 18:59 Quentin Lambert
2014-09-04 21:23 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Quentin Lambert @ 2014-08-04 18:59 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Bjorn Helgaas, Scott Murray,
linux-acpi, linux-pci
Cc: linux-kernel
Patch 1 and 2 fix checkpatch coding style warnings.
Patch 3 fixes chechpatch errors due to assignement
in if conditions.
Quentin Lambert (3):
PCI hotplug: fix a missing space coding style issue
PCI hotplug: fix a simple if coding style issue
PCI hotplug: remove assignement from if conditions
drivers/pci/hotplug/acpi_pcihp.c | 3 ++-
drivers/pci/hotplug/cpcihp_zt5550.c | 42 ++++++++++++++++++-------------------
2 files changed, 23 insertions(+), 22 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 0/3] Fixing checkpatch errors and warnings for PCI hotplug
2014-08-04 18:59 [PATCH 0/3] Fixing checkpatch errors and warnings for PCI hotplug Quentin Lambert
@ 2014-09-04 21:23 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2014-09-04 21:23 UTC (permalink / raw)
To: Quentin Lambert
Cc: Rafael J. Wysocki, Len Brown, Scott Murray, linux-acpi, linux-pci,
linux-kernel
On Mon, Aug 04, 2014 at 08:59:23PM +0200, Quentin Lambert wrote:
> Patch 1 and 2 fix checkpatch coding style warnings.
>
> Patch 3 fixes chechpatch errors due to assignement
> in if conditions.
>
>
> Quentin Lambert (3):
> PCI hotplug: fix a missing space coding style issue
> PCI hotplug: fix a simple if coding style issue
> PCI hotplug: remove assignement from if conditions
I don't mind doing changes like these, but when we do, I want to do the
whole drivers/pci directory at once to minimize the churn. I don't know
how you did these, but it looks like there are more instances than are
fixed by these patches, e.g.,
drivers/pci/hotplug/cpcihp_generic.c: if(!bridge) {
drivers/pci/pci.c: if ((i = pci_save_pcie_state(dev)) != 0)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-04 21:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-04 18:59 [PATCH 0/3] Fixing checkpatch errors and warnings for PCI hotplug Quentin Lambert
2014-09-04 21:23 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).