From: "Chen, Gong" <gong.chen@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: bhelgaas@google.com, rdunlap@infradead.org, tony.luck@intel.com,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/5] RAS, trace: Update error definition format
Date: Wed, 6 Aug 2014 05:08:54 -0400 [thread overview]
Message-ID: <20140806090853.GA21650@gchen.bj.intel.com> (raw)
In-Reply-To: <20140806093223.GA27033@pd.tnic>
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
On Wed, Aug 06, 2014 at 11:32:23AM +0200, Borislav Petkov wrote:
> Date: Wed, 6 Aug 2014 11:32:23 +0200
> From: Borislav Petkov <bp@alien8.de>
> To: "Chen, Gong" <gong.chen@linux.intel.com>
> Cc: bhelgaas@google.com, rdunlap@infradead.org, tony.luck@intel.com,
> linux-pci@vger.kernel.org
> Subject: Re: [PATCH 1/5] RAS, trace: Update error definition format
> User-Agent: Mutt/1.5.23 (2014-03-12)
>
> On Wed, Aug 06, 2014 at 04:32:40AM -0400, Chen, Gong wrote:
> > Previous format definition uses MACRO BIT(...), which is not very
> > maintainable.
>
> What does that "not very maintainable" mean?
>
Bjorn ever mentioned for this:
"I'd like to see all those "BIT(...)" things changed to use the #defines
that already exist in include/uapi/linux/pci_regs.h, e.g.,
PCI_ERR_COR_RCVR. That way grep will find these uses, which will make
maintenance easier."
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-06 9:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 8:32 [PATCH 1/5] RAS, trace: Update error definition format Chen, Gong
2014-08-06 8:32 ` [PATCH 2/5] PCI-e, AER: Replenish missed AER status bits for AER driver Chen, Gong
2014-08-06 8:32 ` [PATCH 3/5] PCI-e, trace: Replenish missed AER status bits for PCIE trace I/F Chen, Gong
2014-08-06 8:32 ` [PATCH 4/5] PCI-e, AER: Make AER UC status naming clearer Chen, Gong
2014-08-06 8:32 ` [RFC PATCH 5/5] PCI, aer: Update initial value of UC error mask Chen, Gong
2014-08-06 9:32 ` [PATCH 1/5] RAS, trace: Update error definition format Borislav Petkov
2014-08-06 9:08 ` Chen, Gong [this message]
2014-08-06 9:59 ` Borislav Petkov
2014-08-07 0:59 ` Chen, Gong
2014-08-10 12:13 ` Chen, Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806090853.GA21650@gchen.bj.intel.com \
--to=gong.chen@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=linux-pci@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).