From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Murali Karicheri <m-karicheri2@ti.com>
Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, bhelgaas@google.com
Subject: Re: [PATCH] PCI: keystone: add a pci quirk to limit mrrs
Date: Wed, 6 Aug 2014 10:30:21 -0600 [thread overview]
Message-ID: <20140806163021.GB19914@obsidianresearch.com> (raw)
In-Reply-To: <1407338300-9146-1-git-send-email-m-karicheri2@ti.com>
On Wed, Aug 06, 2014 at 11:18:20AM -0400, Murali Karicheri wrote:
> Keystone PCI controller has a limitation that memory read request
> size must not exceed 256 bytes. This is a hardware limitation and
> add a quirk to force this limit on all downstream devices by
> updating mrrs.
Does this still work if the tuning is enabled, or does the tuning run
after this?
> + if (pcie_get_readrq(dev) > 256) {
> + pr_info("limiting mrrs to 256\n");
> + pcie_set_readrq(dev, 256);
The pr_info should either go away, or at least print the PCI bdf..
Jason
next prev parent reply other threads:[~2014-08-06 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 15:18 [PATCH] PCI: keystone: add a pci quirk to limit mrrs Murali Karicheri
2014-08-06 16:30 ` Jason Gunthorpe [this message]
2014-08-06 16:56 ` Murali Karicheri
2014-08-06 16:58 ` Jason Gunthorpe
2014-08-06 17:09 ` Murali Karicheri
2014-08-06 17:30 ` Jason Gunthorpe
2014-08-06 19:05 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806163021.GB19914@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=m-karicheri2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).