From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from quartz.orcorp.ca ([184.70.90.242]:47659 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757305AbaHFQ6m (ORCPT ); Wed, 6 Aug 2014 12:58:42 -0400 Date: Wed, 6 Aug 2014 10:58:37 -0600 From: Jason Gunthorpe To: Murali Karicheri Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bhelgaas@google.com Subject: Re: [PATCH] PCI: keystone: add a pci quirk to limit mrrs Message-ID: <20140806165837.GC19914@obsidianresearch.com> References: <1407338300-9146-1-git-send-email-m-karicheri2@ti.com> <20140806163021.GB19914@obsidianresearch.com> <53E25E24.8070506@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <53E25E24.8070506@ti.com> Sender: linux-pci-owner@vger.kernel.org List-ID: On Wed, Aug 06, 2014 at 12:56:04PM -0400, Murali Karicheri wrote: > On 08/06/2014 12:30 PM, Jason Gunthorpe wrote: > >On Wed, Aug 06, 2014 at 11:18:20AM -0400, Murali Karicheri wrote: > >>Keystone PCI controller has a limitation that memory read request > >>size must not exceed 256 bytes. This is a hardware limitation and > >>add a quirk to force this limit on all downstream devices by > >>updating mrrs. > > > >Does this still work if the tuning is enabled, or does the tuning run > >after this? > > Yes it works with tuning enabled. Tuning happens afterwards. The > 'limiting mrrs to 256' below is from my patch. That seems backwards to me... Jason