From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Murali Karicheri <m-karicheri2@ti.com>
Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, bhelgaas@google.com
Subject: Re: [PATCH] PCI: keystone: add a pci quirk to limit mrrs
Date: Wed, 6 Aug 2014 11:30:14 -0600 [thread overview]
Message-ID: <20140806173014.GD19914@obsidianresearch.com> (raw)
In-Reply-To: <53E26155.1020107@ti.com>
On Wed, Aug 06, 2014 at 01:09:41PM -0400, Murali Karicheri wrote:
> >>Yes it works with tuning enabled. Tuning happens afterwards. The
> >>'limiting mrrs to 256' below is from my patch.
> >
> >That seems backwards to me...
> Rational? The tuning is reading mrrs and set mps to less than or
> equal to mrss. So adding this before make sure mrrs used is below
> keystones's limit.
The tuning process adjusts the parameters however it sees fit, todays
algorithm might not increase a BIOS set MRRS, but tomorrow's could.
The quirk should be after the tuning to ensure the MRRS is limited..
Jason
next prev parent reply other threads:[~2014-08-06 17:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 15:18 [PATCH] PCI: keystone: add a pci quirk to limit mrrs Murali Karicheri
2014-08-06 16:30 ` Jason Gunthorpe
2014-08-06 16:56 ` Murali Karicheri
2014-08-06 16:58 ` Jason Gunthorpe
2014-08-06 17:09 ` Murali Karicheri
2014-08-06 17:30 ` Jason Gunthorpe [this message]
2014-08-06 19:05 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806173014.GD19914@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=m-karicheri2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).