linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/1] Replace DEFINE_PCI_DEVICE_TABLE macro use
@ 2014-08-08 13:56 Benoit Taine
  2014-08-08 13:56 ` [PATCH 1/1] " Benoit Taine
  2014-08-12 18:44 ` [PATCH 0/1] " Bjorn Helgaas
  0 siblings, 2 replies; 3+ messages in thread
From: Benoit Taine @ 2014-08-08 13:56 UTC (permalink / raw)
  To: bhelgaas; +Cc: benoit.taine, linux-kernel, linux-pci, kernel-janitors

We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
This issue was reported by checkpatch.

A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/):

// <smpl>

@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@

- DEFINE_PCI_DEVICE_TABLE(i)
+ const struct pci_device_id i[]
= z;

// </smpl>

I previously sent parts of this patch to check wether or not it was
worth sending, and Bjorn answered:
> Benoit, how about if you wait until about half-way through the merge
> window after v3.16 releases, generate an up-to-date single patch, and
> post that?  Then we can try to get it in before v3.17-rc1 to minimize
> merge hassles.

So here it is, based on linux-next on 2014-08-07.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-08-12 18:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-08 13:56 [PATCH 0/1] Replace DEFINE_PCI_DEVICE_TABLE macro use Benoit Taine
2014-08-08 13:56 ` [PATCH 1/1] " Benoit Taine
2014-08-12 18:44 ` [PATCH 0/1] " Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).