* [PATCH 1/1] PCI: spear: Fix build error
@ 2014-08-01 11:28 Sachin Kamat
2014-08-04 7:08 ` Viresh Kumar
2014-08-13 17:20 ` Bjorn Helgaas
0 siblings, 2 replies; 5+ messages in thread
From: Sachin Kamat @ 2014-08-01 11:28 UTC (permalink / raw)
To: linux-pci; +Cc: bhelgaas, pratyush.anand, viresh.kumar, spk.linux, olof
We get the following error when built as a module. Though the general fix would
be in this case to export the below mentioned symbols, considering that
dw_pcie_host_init is marked with __init and other PCI drivers do not support
modular build, I have disabled building this driver as a module too.
ERROR: "dw_pcie_host_init" [drivers/pci/host/pcie-spear13xx.ko] undefined!
ERROR: "dw_handle_msi_irq" [drivers/pci/host/pcie-spear13xx.ko] undefined!
ERROR: "dw_pcie_msi_init" [drivers/pci/host/pcie-spear13xx.ko] undefined!
ERROR: "dw_pcie_cfg_write" [drivers/pci/host/pcie-spear13xx.ko] undefined!
ERROR: "dw_pcie_cfg_read" [drivers/pci/host/pcie-spear13xx.ko] undefined!
ERROR: "dw_pcie_setup_rc" [drivers/pci/host/pcie-spear13xx.ko] undefined!
ERROR: "dw_pcie_link_up" [drivers/pci/host/pcie-spear13xx.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
---
drivers/pci/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index 8922c37..90f5cca 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -56,7 +56,7 @@ config PCI_HOST_GENERIC
controller, such as the one emulated by kvmtool.
config PCIE_SPEAR13XX
- tristate "STMicroelectronics SPEAr PCIe controller"
+ bool "STMicroelectronics SPEAr PCIe controller"
depends on ARCH_SPEAR13XX
select PCIEPORTBUS
select PCIE_DW
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] PCI: spear: Fix build error
2014-08-01 11:28 [PATCH 1/1] PCI: spear: Fix build error Sachin Kamat
@ 2014-08-04 7:08 ` Viresh Kumar
2014-08-05 1:22 ` Jingoo Han
2014-08-13 17:20 ` Bjorn Helgaas
1 sibling, 1 reply; 5+ messages in thread
From: Viresh Kumar @ 2014-08-04 7:08 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas, Pratyush Anand,
Sachin Kamat, olof@lixom.net
On 1 August 2014 16:58, Sachin Kamat <sachin.kamat@samsung.com> wrote:
> We get the following error when built as a module. Though the general fix would
> be in this case to export the below mentioned symbols, considering that
> dw_pcie_host_init is marked with __init and other PCI drivers do not support
> modular build, I have disabled building this driver as a module too.
>
> ERROR: "dw_pcie_host_init" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> ERROR: "dw_handle_msi_irq" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> ERROR: "dw_pcie_msi_init" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> ERROR: "dw_pcie_cfg_write" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> ERROR: "dw_pcie_cfg_read" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> ERROR: "dw_pcie_setup_rc" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> ERROR: "dw_pcie_link_up" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> ---
> drivers/pci/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 8922c37..90f5cca 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -56,7 +56,7 @@ config PCI_HOST_GENERIC
> controller, such as the one emulated by kvmtool.
>
> config PCIE_SPEAR13XX
> - tristate "STMicroelectronics SPEAr PCIe controller"
> + bool "STMicroelectronics SPEAr PCIe controller"
> depends on ARCH_SPEAR13XX
> select PCIEPORTBUS
> select PCIE_DW
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] PCI: spear: Fix build error
2014-08-04 7:08 ` Viresh Kumar
@ 2014-08-05 1:22 ` Jingoo Han
0 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2014-08-05 1:22 UTC (permalink / raw)
To: 'Viresh Kumar', 'Sachin Kamat'
Cc: linux-pci, 'Bjorn Helgaas', 'Pratyush Anand',
'Sachin Kamat', olof, 'Jingoo Han'
On Monday, August 04, 2014 4:09 PM, Sachin Kamat wrote:
> On 1 August 2014 16:58, Sachin Kamat <sachin.kamat@samsung.com> wrote:
> > We get the following error when built as a module. Though the general fix would
> > be in this case to export the below mentioned symbols, considering that
> > dw_pcie_host_init is marked with __init and other PCI drivers do not support
> > modular build, I have disabled building this driver as a module too.
> >
> > ERROR: "dw_pcie_host_init" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_handle_msi_irq" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_pcie_msi_init" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_pcie_cfg_write" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_pcie_cfg_read" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_pcie_setup_rc" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_pcie_link_up" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
In order to use PCI host drivers as the module, we need to
do additional works. Actually, it was already discussed in
other threads. However, it is not sure that who will do this
work. Thanks!
Best regards,
Jingoo Han
> > ---
> > drivers/pci/host/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> > index 8922c37..90f5cca 100644
> > --- a/drivers/pci/host/Kconfig
> > +++ b/drivers/pci/host/Kconfig
> > @@ -56,7 +56,7 @@ config PCI_HOST_GENERIC
> > controller, such as the one emulated by kvmtool.
> >
> > config PCIE_SPEAR13XX
> > - tristate "STMicroelectronics SPEAr PCIe controller"
> > + bool "STMicroelectronics SPEAr PCIe controller"
> > depends on ARCH_SPEAR13XX
> > select PCIEPORTBUS
> > select PCIE_DW
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] PCI: spear: Fix build error
2014-08-01 11:28 [PATCH 1/1] PCI: spear: Fix build error Sachin Kamat
2014-08-04 7:08 ` Viresh Kumar
@ 2014-08-13 17:20 ` Bjorn Helgaas
2014-09-17 5:10 ` Bjorn Helgaas
1 sibling, 1 reply; 5+ messages in thread
From: Bjorn Helgaas @ 2014-08-13 17:20 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-pci, pratyush.anand, viresh.kumar, spk.linux, olof
On Fri, Aug 01, 2014 at 04:58:34PM +0530, Sachin Kamat wrote:
> We get the following error when built as a module. Though the general fix would
> be in this case to export the below mentioned symbols, considering that
> dw_pcie_host_init is marked with __init and other PCI drivers do not support
> modular build, I have disabled building this driver as a module too.
>
> ERROR: "dw_pcie_host_init" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> ERROR: "dw_handle_msi_irq" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> ERROR: "dw_pcie_msi_init" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> ERROR: "dw_pcie_cfg_write" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> ERROR: "dw_pcie_cfg_read" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> ERROR: "dw_pcie_setup_rc" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> ERROR: "dw_pcie_link_up" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
Applied with ack and reviewed-by from Viresh and Jingoo to pci/spear for
v3.17, thanks!
> ---
> drivers/pci/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 8922c37..90f5cca 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -56,7 +56,7 @@ config PCI_HOST_GENERIC
> controller, such as the one emulated by kvmtool.
>
> config PCIE_SPEAR13XX
> - tristate "STMicroelectronics SPEAr PCIe controller"
> + bool "STMicroelectronics SPEAr PCIe controller"
> depends on ARCH_SPEAR13XX
> select PCIEPORTBUS
> select PCIE_DW
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] PCI: spear: Fix build error
2014-08-13 17:20 ` Bjorn Helgaas
@ 2014-09-17 5:10 ` Bjorn Helgaas
0 siblings, 0 replies; 5+ messages in thread
From: Bjorn Helgaas @ 2014-09-17 5:10 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-pci, pratyush.anand, viresh.kumar, spk.linux, olof
On Wed, Aug 13, 2014 at 11:20:32AM -0600, Bjorn Helgaas wrote:
> On Fri, Aug 01, 2014 at 04:58:34PM +0530, Sachin Kamat wrote:
> > We get the following error when built as a module. Though the general fix would
> > be in this case to export the below mentioned symbols, considering that
> > dw_pcie_host_init is marked with __init and other PCI drivers do not support
> > modular build, I have disabled building this driver as a module too.
> >
> > ERROR: "dw_pcie_host_init" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_handle_msi_irq" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_pcie_msi_init" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_pcie_cfg_write" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_pcie_cfg_read" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_pcie_setup_rc" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_pcie_link_up" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
>
> Applied with ack and reviewed-by from Viresh and Jingoo to pci/spear for
> v3.17, thanks!
Sorry, I misplaced this somehow. I did it again and it's now in my
for-linus branch, so it should still make it for v3.17. Sorry about that.
> > ---
> > drivers/pci/host/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> > index 8922c37..90f5cca 100644
> > --- a/drivers/pci/host/Kconfig
> > +++ b/drivers/pci/host/Kconfig
> > @@ -56,7 +56,7 @@ config PCI_HOST_GENERIC
> > controller, such as the one emulated by kvmtool.
> >
> > config PCIE_SPEAR13XX
> > - tristate "STMicroelectronics SPEAr PCIe controller"
> > + bool "STMicroelectronics SPEAr PCIe controller"
> > depends on ARCH_SPEAR13XX
> > select PCIEPORTBUS
> > select PCIE_DW
> > --
> > 1.8.1.2
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-17 5:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-01 11:28 [PATCH 1/1] PCI: spear: Fix build error Sachin Kamat
2014-08-04 7:08 ` Viresh Kumar
2014-08-05 1:22 ` Jingoo Han
2014-08-13 17:20 ` Bjorn Helgaas
2014-09-17 5:10 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).