* [PATCH] PCI: Add another ID for Intel GPU "spurious interrupt" quirk
@ 2014-08-08 13:54 Thomas Jarosch
2014-08-08 15:24 ` [Intel-gfx] " Daniel Vetter
2014-09-05 17:34 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Jarosch @ 2014-08-08 13:54 UTC (permalink / raw)
To: linux-pci; +Cc: Bjorn Helgaas, intel-gfx
New Intel G3258 CPU, new MSI board, same problem:
The GPU interrupt fired like crazy on monitor unplug.
lspci output:
00:02.0 VGA compatible controller: Intel Corporation Device 0402 (rev 06)
Subsystem: Micro-Star International Co., Ltd. Device 7817
Flags: bus master, fast devsel, latency 0, IRQ 11
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Tested-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
CC: stable@vger.kernel.org # v3.4+
---
drivers/pci/quirks.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 80c2d01..d2ff39d 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2940,6 +2940,7 @@ static void disable_igfx_irq(struct pci_dev *dev)
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0102, disable_igfx_irq);
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x010a, disable_igfx_irq);
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0152, disable_igfx_irq);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0402, disable_igfx_irq);
/*
* PCI devices which are on Intel chips can skip the 10ms delay
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Intel-gfx] [PATCH] PCI: Add another ID for Intel GPU "spurious interrupt" quirk
2014-08-08 13:54 [PATCH] PCI: Add another ID for Intel GPU "spurious interrupt" quirk Thomas Jarosch
@ 2014-08-08 15:24 ` Daniel Vetter
2014-09-05 17:34 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2014-08-08 15:24 UTC (permalink / raw)
To: Thomas Jarosch; +Cc: linux-pci, Bjorn Helgaas, intel-gfx
On Fri, Aug 08, 2014 at 03:54:04PM +0200, Thomas Jarosch wrote:
> New Intel G3258 CPU, new MSI board, same problem:
> The GPU interrupt fired like crazy on monitor unplug.
>
> lspci output:
> 00:02.0 VGA compatible controller: Intel Corporation Device 0402 (rev 06)
> Subsystem: Micro-Star International Co., Ltd. Device 7817
> Flags: bus master, fast devsel, latency 0, IRQ 11
>
> Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> Tested-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> CC: stable@vger.kernel.org # v3.4+
> ---
> drivers/pci/quirks.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 80c2d01..d2ff39d 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -2940,6 +2940,7 @@ static void disable_igfx_irq(struct pci_dev *dev)
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0102, disable_igfx_irq);
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x010a, disable_igfx_irq);
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0152, disable_igfx_irq);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0402, disable_igfx_irq);
Shouldn't we just add entries for them all? See include/drm/i915_pciids.h
We might need to abstract the macro magic a bit though to reuse that list.
Also note that not all have the DEIER register. In any case I don't think
this game of whack-a-mole here is, we should plug this all for real.
-Daniel
>
> /*
> * PCI devices which are on Intel chips can skip the 10ms delay
> --
> 1.9.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: Add another ID for Intel GPU "spurious interrupt" quirk
2014-08-08 13:54 [PATCH] PCI: Add another ID for Intel GPU "spurious interrupt" quirk Thomas Jarosch
2014-08-08 15:24 ` [Intel-gfx] " Daniel Vetter
@ 2014-09-05 17:34 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2014-09-05 17:34 UTC (permalink / raw)
To: Thomas Jarosch; +Cc: linux-pci, intel-gfx
On Fri, Aug 08, 2014 at 03:54:04PM +0200, Thomas Jarosch wrote:
> New Intel G3258 CPU, new MSI board, same problem:
> The GPU interrupt fired like crazy on monitor unplug.
>
> lspci output:
> 00:02.0 VGA compatible controller: Intel Corporation Device 0402 (rev 06)
> Subsystem: Micro-Star International Co., Ltd. Device 7817
> Flags: bus master, fast devsel, latency 0, IRQ 11
>
> Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> Tested-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> CC: stable@vger.kernel.org # v3.4+
Dropping for now, please resend if necessary after resolving Daniel's
question.
> ---
> drivers/pci/quirks.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 80c2d01..d2ff39d 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -2940,6 +2940,7 @@ static void disable_igfx_irq(struct pci_dev *dev)
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0102, disable_igfx_irq);
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x010a, disable_igfx_irq);
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0152, disable_igfx_irq);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0402, disable_igfx_irq);
>
> /*
> * PCI devices which are on Intel chips can skip the 10ms delay
> --
> 1.9.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-05 17:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-08 13:54 [PATCH] PCI: Add another ID for Intel GPU "spurious interrupt" quirk Thomas Jarosch
2014-08-08 15:24 ` [Intel-gfx] " Daniel Vetter
2014-09-05 17:34 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).