From: Quentin Lambert <lambert.quentin@gmail.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
Scott Murray <scott@spiteful.org>
Cc: linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/4] Extending the first version of the patch to the entire directory
Date: Sun, 7 Sep 2014 20:00:23 +0200 [thread overview]
Message-ID: <20140907180023.GA1849@greed> (raw)
Patch 1 and 2 are straight forward extension from the previous version
of the patch.
Patch 3 introduces checkpatch warning due to lines surpassing 80
characters. Another warning concerning too many preceding tabs
is not fixed either.
Patch 4 are less straight forward similar modifications
the modification made to ibmphp_res.c change the value of len_tmp
when the first condition in if statement is not met.
I wasn't quite sure how to solve elegantly the checkpatch error for
slot.c, I chose to use a label and gotos since it was already used
and allowed for a slight code factorisation. This being my first patch I
understand that this may not be the best solution.
Quentin Lambert (4):
PCI: fix a missing space coding style issue
PCI: fix a simple if coding style issue
PCI: remove assignement from if conditions
PCI: remove assignement in non straight forward if condition
drivers/pci/hotplug/acpi_pcihp.c | 3 ++-
drivers/pci/hotplug/acpiphp_ibm.c | 2 +-
drivers/pci/hotplug/cpci_hotplug_core.c | 13 ++++++----
drivers/pci/hotplug/cpcihp_generic.c | 28 ++++++++++-----------
drivers/pci/hotplug/cpcihp_zt5550.c | 44 ++++++++++++++++-----------------
drivers/pci/hotplug/cpqphp.h | 2 +-
drivers/pci/hotplug/cpqphp_core.c | 3 +--
drivers/pci/hotplug/cpqphp_ctrl.c | 19 ++++++--------
drivers/pci/hotplug/cpqphp_nvram.c | 13 ++++------
drivers/pci/hotplug/ibmphp_core.c | 19 ++++++++------
drivers/pci/hotplug/ibmphp_ebda.c | 3 +--
drivers/pci/hotplug/ibmphp_hpc.c | 3 +--
drivers/pci/hotplug/ibmphp_pci.c | 6 +++--
drivers/pci/hotplug/ibmphp_res.c | 43 ++++++++++++++++++++++----------
drivers/pci/hotplug/shpchp_ctrl.c | 12 ++++++---
drivers/pci/hotplug/shpchp_hpc.c | 3 ++-
drivers/pci/pci.c | 19 +++++++++++---
drivers/pci/slot.c | 12 +++++++--
18 files changed, 143 insertions(+), 104 deletions(-)
--
1.9.1
next reply other threads:[~2014-09-07 18:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 18:00 Quentin Lambert [this message]
2014-09-24 17:42 ` [PATCH v2 0/4] Extending the first version of the patch to the entire directory Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140907180023.GA1849@greed \
--to=lambert.quentin@gmail.com \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=scott@spiteful.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).