From: Bjorn Helgaas <bhelgaas@google.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Srikanth Thokala <sthokal@xilinx.com>,
Michal Simek <michal.simek@xilinx.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] PCI: xilinx: testing wrong variable in setup irq function
Date: Tue, 16 Sep 2014 17:47:04 -0600 [thread overview]
Message-ID: <20140916234704.GK5050@google.com> (raw)
In-Reply-To: <20140909121150.GD19760@mwanda>
On Tue, Sep 09, 2014 at 03:11:50PM +0300, Dan Carpenter wrote:
> We should be testing "hwirq" instead of "irq". "irq" is unsigned so
> it's never less than zero. Also it's uninitialized.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied with Srikanth's ack to pci/host-xilinx for v3.18, thanks.
>
> diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c
> index 44f8944..ccc496b 100644
> --- a/drivers/pci/host/pcie-xilinx.c
> +++ b/drivers/pci/host/pcie-xilinx.c
> @@ -359,8 +359,8 @@ static int xilinx_pcie_msi_setup_irq(struct msi_chip *chip,
> phys_addr_t msg_addr;
>
> hwirq = xilinx_pcie_assign_msi(port);
> - if (irq < 0)
> - return irq;
> + if (hwirq < 0)
> + return hwirq;
>
> irq = irq_create_mapping(port->irq_domain, hwirq);
> if (!irq)
prev parent reply other threads:[~2014-09-16 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 12:11 [patch] PCI: xilinx: testing wrong variable in setup irq function Dan Carpenter
2014-09-09 12:31 ` Srikanth Thokala
2014-09-16 23:47 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916234704.GK5050@google.com \
--to=bhelgaas@google.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=grant.likely@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sthokal@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).