From: Bjorn Helgaas <bhelgaas@google.com>
To: Sachin Kamat <sachin.kamat@samsung.com>
Cc: linux-pci@vger.kernel.org, pratyush.anand@st.com,
viresh.kumar@linaro.org, spk.linux@gmail.com, olof@lixom.net
Subject: Re: [PATCH 1/1] PCI: spear: Fix build error
Date: Tue, 16 Sep 2014 23:10:24 -0600 [thread overview]
Message-ID: <20140917051024.GA21020@google.com> (raw)
In-Reply-To: <20140813172032.GA7298@google.com>
On Wed, Aug 13, 2014 at 11:20:32AM -0600, Bjorn Helgaas wrote:
> On Fri, Aug 01, 2014 at 04:58:34PM +0530, Sachin Kamat wrote:
> > We get the following error when built as a module. Though the general fix would
> > be in this case to export the below mentioned symbols, considering that
> > dw_pcie_host_init is marked with __init and other PCI drivers do not support
> > modular build, I have disabled building this driver as a module too.
> >
> > ERROR: "dw_pcie_host_init" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_handle_msi_irq" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_pcie_msi_init" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_pcie_cfg_write" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_pcie_cfg_read" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_pcie_setup_rc" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > ERROR: "dw_pcie_link_up" [drivers/pci/host/pcie-spear13xx.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
>
> Applied with ack and reviewed-by from Viresh and Jingoo to pci/spear for
> v3.17, thanks!
Sorry, I misplaced this somehow. I did it again and it's now in my
for-linus branch, so it should still make it for v3.17. Sorry about that.
> > ---
> > drivers/pci/host/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> > index 8922c37..90f5cca 100644
> > --- a/drivers/pci/host/Kconfig
> > +++ b/drivers/pci/host/Kconfig
> > @@ -56,7 +56,7 @@ config PCI_HOST_GENERIC
> > controller, such as the one emulated by kvmtool.
> >
> > config PCIE_SPEAR13XX
> > - tristate "STMicroelectronics SPEAr PCIe controller"
> > + bool "STMicroelectronics SPEAr PCIe controller"
> > depends on ARCH_SPEAR13XX
> > select PCIEPORTBUS
> > select PCIE_DW
> > --
> > 1.8.1.2
> >
prev parent reply other threads:[~2014-09-17 5:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 11:28 [PATCH 1/1] PCI: spear: Fix build error Sachin Kamat
2014-08-04 7:08 ` Viresh Kumar
2014-08-05 1:22 ` Jingoo Han
2014-08-13 17:20 ` Bjorn Helgaas
2014-09-17 5:10 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917051024.GA21020@google.com \
--to=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=olof@lixom.net \
--cc=pratyush.anand@st.com \
--cc=sachin.kamat@samsung.com \
--cc=spk.linux@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).