From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss-mx-na.foss.arm.com ([217.140.108.86]:36847 "EHLO foss-mx-na.foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751883AbaIXRLJ (ORCPT ); Wed, 24 Sep 2014 13:11:09 -0400 Date: Wed, 24 Sep 2014 18:10:48 +0100 From: Catalin Marinas To: Robert Richter Cc: Arnd Bergmann , Robert Richter , Bjorn Helgaas , Will Deacon , Liviu Dudau , Rob Herring , Sunil Goutham , "linux-arm-kernel@lists.infradead.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 5/6] arm64, defconfig: Enable PCI Message-ID: <20140924171047.GO15842@e104818-lin.cambridge.arm.com> References: <1411573068-12952-1-git-send-email-rric@kernel.org> <1411573068-12952-6-git-send-email-rric@kernel.org> <7901403.qjKNmO519a@wuerfel> <20140924162631.GI31556@rric.localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20140924162631.GI31556@rric.localhost> Sender: linux-pci-owner@vger.kernel.org List-ID: On Wed, Sep 24, 2014 at 05:26:31PM +0100, Robert Richter wrote: > On 24.09.14 18:14:11, Arnd Bergmann wrote: > > On Wednesday 24 September 2014 17:37:47 Robert Richter wrote: > > > config PCI > > > bool "PCI support" > > > + default y > > > help > > > This feature enables support for PCIe bus system. If you say Y > > > here, the kernel will include drivers and infrastructure code > > > to support PCIe bus devices. > > > > > > +config PCI_MSI > > > + def_bool PCI > > > + > > > config PCI_DOMAINS > > > def_bool PCI > > > > There is already a PCI_MSI symbol in drivers/pci/Kconfig. Just select that > > from the PCI symbol above rather than defining a second one. > > The intention is not to have a second definition, instead this should > enable the default value just for arm64. Thus I put it to > arch/arm64/Kconfig. Otherwise it would be enabled per default on all > archs. > > We could have used select in config ARM64, but I tried to avoid using > select due to the dependency issue and instead implement this with > default-y/depends-on. Doing so it can be manually disabled too. It may be better to simply set PCI and PCI_MSI as defaults in defconfig rather than "default y" and an additional config PCI_MSI entry. -- Catalin