[PATCH v2 0/4] Extending the first version of the patch to the entire directory

[PATCH v2 0/4] Extending the first version of the patch to the entire directory

[Quentin Lambert]

Patch 1 and 2 are straight forward extension from the previous version
of the patch.

Patch 3 introduces checkpatch warning due to lines surpassing 80
characters. Another warning concerning too many preceding tabs
is not fixed either.

Patch 4 are less straight forward similar modifications
the modification made to ibmphp_res.c change the value of len_tmp
when the first condition in if statement is not met.
I wasn't quite sure how to solve elegantly the checkpatch error for
slot.c, I chose to use a label and gotos since it was already used
and allowed for a slight code factorisation. This being my first patch I
understand that this may not be the best solution.



Quentin Lambert (4):
  PCI: fix a missing space coding style issue
  PCI: fix a simple if coding style issue
  PCI: remove assignement from if conditions
  PCI: remove assignement in non straight forward if condition

 drivers/pci/hotplug/acpi_pcihp.c        |  3 ++-
 drivers/pci/hotplug/acpiphp_ibm.c       |  2 +-
 drivers/pci/hotplug/cpci_hotplug_core.c | 13 ++++++----
 drivers/pci/hotplug/cpcihp_generic.c    | 28 ++++++++++-----------
 drivers/pci/hotplug/cpcihp_zt5550.c     | 44 ++++++++++++++++-----------------
 drivers/pci/hotplug/cpqphp.h            |  2 +-
 drivers/pci/hotplug/cpqphp_core.c       |  3 +--
 drivers/pci/hotplug/cpqphp_ctrl.c       | 19 ++++++--------
 drivers/pci/hotplug/cpqphp_nvram.c      | 13 ++++------
 drivers/pci/hotplug/ibmphp_core.c       | 19 ++++++++------
 drivers/pci/hotplug/ibmphp_ebda.c       |  3 +--
 drivers/pci/hotplug/ibmphp_hpc.c        |  3 +--
 drivers/pci/hotplug/ibmphp_pci.c        |  6 +++--
 drivers/pci/hotplug/ibmphp_res.c        | 43 ++++++++++++++++++++++----------
 drivers/pci/hotplug/shpchp_ctrl.c       | 12 ++++++---
 drivers/pci/hotplug/shpchp_hpc.c        |  3 ++-
 drivers/pci/pci.c                       | 19 +++++++++++---
 drivers/pci/slot.c                      | 12 +++++++--
 18 files changed, 143 insertions(+), 104 deletions(-)

-- 
1.9.1

Re: [PATCH v2 0/4] Extending the first version of the patch to the entire directory

[Bjorn Helgaas]

On Sun, Sep 07, 2014 at 08:00:23PM +0200, Quentin Lambert wrote:
> Patch 1 and 2 are straight forward extension from the previous version
> of the patch.
> 
> Patch 3 introduces checkpatch warning due to lines surpassing 80
> characters. Another warning concerning too many preceding tabs
> is not fixed either.
> 
> Patch 4 are less straight forward similar modifications
> the modification made to ibmphp_res.c change the value of len_tmp
> when the first condition in if statement is not met.
> I wasn't quite sure how to solve elegantly the checkpatch error for
> slot.c, I chose to use a label and gotos since it was already used
> and allowed for a slight code factorisation. This being my first patch I
> understand that this may not be the best solution.

Thanks for splitting out patch 4 from 3; it definitely made it easier to
review.

I dropped a couple bits from patch 4 that I'll mention in a reply to that patch.

I applied the rest to pci/cleanup and plan to merge it toward the end of
the v3.18 merge window, thanks!

Bjorn

> Quentin Lambert (4):
>   PCI: fix a missing space coding style issue
>   PCI: fix a simple if coding style issue
>   PCI: remove assignement from if conditions
>   PCI: remove assignement in non straight forward if condition
> 
>  drivers/pci/hotplug/acpi_pcihp.c        |  3 ++-
>  drivers/pci/hotplug/acpiphp_ibm.c       |  2 +-
>  drivers/pci/hotplug/cpci_hotplug_core.c | 13 ++++++----
>  drivers/pci/hotplug/cpcihp_generic.c    | 28 ++++++++++-----------
>  drivers/pci/hotplug/cpcihp_zt5550.c     | 44 ++++++++++++++++-----------------
>  drivers/pci/hotplug/cpqphp.h            |  2 +-
>  drivers/pci/hotplug/cpqphp_core.c       |  3 +--
>  drivers/pci/hotplug/cpqphp_ctrl.c       | 19 ++++++--------
>  drivers/pci/hotplug/cpqphp_nvram.c      | 13 ++++------
>  drivers/pci/hotplug/ibmphp_core.c       | 19 ++++++++------
>  drivers/pci/hotplug/ibmphp_ebda.c       |  3 +--
>  drivers/pci/hotplug/ibmphp_hpc.c        |  3 +--
>  drivers/pci/hotplug/ibmphp_pci.c        |  6 +++--
>  drivers/pci/hotplug/ibmphp_res.c        | 43 ++++++++++++++++++++++----------
>  drivers/pci/hotplug/shpchp_ctrl.c       | 12 ++++++---
>  drivers/pci/hotplug/shpchp_hpc.c        |  3 ++-
>  drivers/pci/pci.c                       | 19 +++++++++++---
>  drivers/pci/slot.c                      | 12 +++++++--
>  18 files changed, 143 insertions(+), 104 deletions(-)
> 
> -- 
> 1.9.1
>