From: Bjorn Helgaas <bhelgaas@google.com>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: "matt@masarand.com" <matt@masarand.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 01/18] Added way to register deferred PCI IRQ assignment handlers
Date: Tue, 14 Oct 2014 17:25:18 -0600 [thread overview]
Message-ID: <20141014232518.GA15225@google.com> (raw)
In-Reply-To: <20141002103315.GM841@e106497-lin.cambridge.arm.com>
On Thu, Oct 02, 2014 at 11:33:15AM +0100, Liviu Dudau wrote:
> On Thu, Oct 02, 2014 at 05:07:29AM +0100, matt@masarand.com wrote:
> > From: Matthew Minter <matt@masarand.com>
> >
>
> Hi Matthew,
>
> Some comments below:
Hi Liviu,
Thank you very much for reviewing this! Sorry that I didn't notice your
comments until later (mutt email-reading snafu on my end), so I duplicated
some of your thoughts. This was just out of my ignorance, not because I'm
taking issue with your comments.
> > -static struct pci_host_bridge *find_pci_host_bridge(struct pci_bus *bus)
> > +struct pci_host_bridge *find_pci_host_bridge(struct pci_bus *bus)
>
> When I did the same thing in one of the versions of my generic host bridge series,
> Bjorn has mentioned that he would like the name to be changed to pci_xxxxx to
> make clear that the function is now public.
This particular one is not a big deal to me because it's in
drivers/pci/pci.h, which is really only for use inside the PCI core. It's
when we expose things in include/linux/pci.h, and especially when we export
things for use by modules, that I think we should be careful to use a
consistent namespace.
Bjorn
next prev parent reply other threads:[~2014-10-14 23:25 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 4:07 [PATCH V3] Delay allocation of PCI device IRQs from boot time until bus scan time to fix PCI hotplugging matt
2014-10-02 4:07 ` [PATCH 01/18] Added way to register deferred PCI IRQ assignment handlers matt
2014-10-02 10:33 ` Liviu Dudau
2014-10-14 23:25 ` Bjorn Helgaas [this message]
2014-10-14 17:15 ` Bjorn Helgaas
2014-10-02 4:07 ` [PATCH 02/18] Delayed x86 setup of PCI IRQs to bus scan time matt
2014-10-02 10:51 ` Liviu Dudau
2014-10-14 18:11 ` Bjorn Helgaas
2014-10-02 4:07 ` [PATCH 03/18] Delayed arm " matt
2014-10-14 18:14 ` Bjorn Helgaas
2014-10-02 4:07 ` [PATCH 04/18] Delayed powerpc " matt
2014-10-14 18:20 ` Bjorn Helgaas
2014-10-02 4:07 ` [PATCH 05/18] Delayed sh " matt
2014-10-14 18:25 ` Bjorn Helgaas
2014-10-02 4:07 ` [PATCH 06/18] Delayed alpha " matt
2014-10-14 18:27 ` Bjorn Helgaas
2014-10-02 4:07 ` [PATCH 07/18] Delayed cris " matt
2014-10-14 18:34 ` Bjorn Helgaas
2014-10-02 4:07 ` [PATCH 08/18] Delayed frv " matt
2014-10-14 18:37 ` Bjorn Helgaas
2014-10-02 4:07 ` [PATCH 09/18] Delayed m68k " matt
2014-10-14 18:38 ` Bjorn Helgaas
2014-10-02 4:07 ` [PATCH 10/18] Delayed microblaze " matt
2014-10-02 4:07 ` [PATCH 11/18] Delayed mips " matt
2014-10-02 4:07 ` [PATCH 12/18] Delayed mn10300 " matt
2014-10-14 18:46 ` Bjorn Helgaas
2014-10-02 4:07 ` [PATCH 13/18] Delayed sparc " matt
2014-10-14 18:51 ` Bjorn Helgaas
2014-10-02 4:07 ` [PATCH 14/18] Delayed tile " matt
2014-10-02 4:07 ` [PATCH 15/18] Delayed unicore32 " matt
2014-10-02 4:07 ` [PATCH 16/18] Disabled bus scan time PCI IRQ assignment on ia64 matt
2014-10-14 18:53 ` Bjorn Helgaas
2014-10-02 4:07 ` [PATCH 17/18] Disabled bus scan time PCI IRQ assignment on parisc matt
2014-10-02 4:07 ` [PATCH 18/18] Disabled bus scan time PCI IRQ assignment on s390 matt
2015-01-31 14:56 ` [PATCH V3] Delay allocation of PCI device IRQs from boot time until bus scan time to fix PCI hotplugging Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2014-10-02 3:50 matt
2014-10-02 3:50 ` [PATCH 01/18] Added way to register deferred PCI IRQ assignment handlers matt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014232518.GA15225@google.com \
--to=bhelgaas@google.com \
--cc=Liviu.Dudau@arm.com \
--cc=linux-pci@vger.kernel.org \
--cc=matt@masarand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).