From: Bjorn Helgaas <bhelgaas@google.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: l.stach@pengutronix.de, Hong-Xing.Zhu@freescale.com,
linux-pci@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>,
Richard Zhu <r65037@freescale.com>, Rob Herring <robh@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: imx6q-pcie doc: Update the clocks descriptions to use defines
Date: Tue, 14 Oct 2014 18:17:46 -0600 [thread overview]
Message-ID: <20141015001746.GC15225@google.com> (raw)
In-Reply-To: <1412434548-11219-1-git-send-email-festevam@gmail.com>
[+cc Rob, Arnd, linux-arm-kernel]
On Sat, Oct 04, 2014 at 11:55:48AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Let's make the imx6q-pcie example to actually match the usage on imx6qdl.dtsi
> by providing the clock names via defines rather than hardcoded numbers.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Is this an arm-soc thing?
If you want me to take it, I'll wait for an ack from the likes of
Richard/Lucas/Rob/Arnd since I can't review this myself.
> ---
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> index 6fbba53..0b28b52 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> @@ -35,6 +35,8 @@ Example:
> <0 0 0 2 &intc GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
> <0 0 0 3 &intc GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
> <0 0 0 4 &intc GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&clks 144>, <&clks 206>, <&clks 189>;
> + clocks = <&clks IMX6QDL_CLK_PCIE_AXI>,
> + <&clks IMX6QDL_CLK_LVDS1_GATE>,
> + <&clks IMX6QDL_CLK_PCIE_REF_125M>;
> clock-names = "pcie", "pcie_bus", "pcie_phy";
> };
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-10-15 0:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-04 14:55 [PATCH] PCI: imx6q-pcie doc: Update the clocks descriptions to use defines Fabio Estevam
2014-10-15 0:17 ` Bjorn Helgaas [this message]
2014-10-15 8:28 ` Hong-Xing.Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015001746.GC15225@google.com \
--to=bhelgaas@google.com \
--cc=Hong-Xing.Zhu@freescale.com \
--cc=arnd@arndb.de \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=r65037@freescale.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).