[PATCH RFC 1/2] drivers: pci: fix pci_mmap_fits() implementation for procfs mmap

[PATCH RFC 1/2] drivers: pci: fix pci_mmap_fits() implementation for procfs mmap

[Lorenzo Pieralisi]

The addresses stored in PCI device resources for memory spaces
correspond to CPU physical addresses, which do not necessarily
map 1:1 to PCI bus addresses as programmed in PCI devices configuration
spaces.

Therefore, the changes applied by commits:

8c05cd08a7504b855c26526
3b519e4ea618b6943a82931

imply that the sanity checks carried out in pci_mmap_fits() to
ensure that the user executes an mmap of a "real" pci resource are
erroneous when executed through procfs. Some platforms (ie SPARC)
expect the offset value to be passed in (procfs mapping) to be the
PCI BAR configuration value as read from the PCI device configuration
space, not the fixed-up CPU physical address that is present in PCI
device resources.

The required pgoff (offset in mmap syscall) value passed from userspace
is supposed to represent the resource value exported through
/proc/bus/pci/devices when the resource is mmapped though procfs (and 0
when the mapping is carried out through sysfs resource files), which
corresponds to the PCI resource filtered through the pci_resource_to_user()
API.

This patch converts the PCI resource to the expected "user visible"
value through pci_resource_to_user() before carrying out sanity checks
in pci_mmap_fits() so that the check is carried out on the resource
values as expected from the userspace mmap API.

Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: David S. Miller <davem@davemloft.net>
Cc: Michal Simek <monstr@monstr.eu>
Cc: Martin Wilck <martin.wilck@ts.fujitsu.com>
Cc: Derrick J. Wong <djwong@us.ibm.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
---
 drivers/pci/pci-sysfs.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 92b6d9a..777d8bc 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -963,17 +963,20 @@ void pci_remove_legacy_files(struct pci_bus *b)
 int pci_mmap_fits(struct pci_dev *pdev, int resno, struct vm_area_struct *=
vma,
 =09=09  enum pci_mmap_api mmap_api)
 {
-=09unsigned long nr, start, size, pci_start;
+=09unsigned long nr, start, size, pci_offset;
+=09resource_size_t pci_start, pci_end;
=20
 =09if (pci_resource_len(pdev, resno) =3D=3D 0)
 =09=09return 0;
 =09nr =3D vma_pages(vma);
 =09start =3D vma->vm_pgoff;
+=09pci_resource_to_user(pdev, resno, &pdev->resource[resno],
+=09=09=09     &pci_start, &pci_end);
 =09size =3D ((pci_resource_len(pdev, resno) - 1) >> PAGE_SHIFT) + 1;
-=09pci_start =3D (mmap_api =3D=3D PCI_MMAP_PROCFS) ?
-=09=09=09pci_resource_start(pdev, resno) >> PAGE_SHIFT : 0;
-=09if (start >=3D pci_start && start < pci_start + size &&
-=09=09=09start + nr <=3D pci_start + size)
+=09pci_offset =3D (mmap_api =3D=3D PCI_MMAP_PROCFS) ?
+=09=09=09pci_start >> PAGE_SHIFT : 0;
+=09if (start >=3D pci_offset && start < pci_offset + size &&
+=09=09=09start + nr <=3D pci_offset + size)
 =09=09return 1;
 =09return 0;
 }
--=20
2.1.2

[PATCH RFC 2/2] arm: kernel: fix pci_mmap_page_range() offset calculation

[Lorenzo Pieralisi]

The pci_mmap_page_range() API should be written to expect offset
values representing PCI memory resource addresses as seen by user space,
through the pci_resource_to_user() API.

ARM relies on the standard implementation of pci_resource_to_user()
which actually is an identity map and exports to user space
PCI memory resources as they are stored in PCI devices resources (ie BARs)
which represent CPU physical addresses (fixed-up using BUS to CPU
address conversions) not PCI bus addresses.

On platforms where the mapping between CPU and BUS address is not a 1:1
mapping this is erroneous, in that an additional shift is applied to
an already fixed-up offset passed from userspace.

Hence, this patch removes the mem_offset from the pgoff calculation
since the offset as passed from user space already represents
the CPU physical address corresponding to the resource to be mapped,
ie no additional offset should be applied.

Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
---
 arch/arm/kernel/bios32.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c
index 17a26c1..b56fa2d 100644
--- a/arch/arm/kernel/bios32.c
+++ b/arch/arm/kernel/bios32.c
@@ -626,21 +626,15 @@ int pcibios_enable_device(struct pci_dev *dev, int ma=
sk)
 int pci_mmap_page_range(struct pci_dev *dev, struct vm_area_struct *vma,
 =09=09=09enum pci_mmap_state mmap_state, int write_combine)
 {
-=09struct pci_sys_data *root =3D dev->sysdata;
-=09unsigned long phys;
-
-=09if (mmap_state =3D=3D pci_mmap_io) {
+=09if (mmap_state =3D=3D pci_mmap_io)
 =09=09return -EINVAL;
-=09} else {
-=09=09phys =3D vma->vm_pgoff + (root->mem_offset >> PAGE_SHIFT);
-=09}
=20
 =09/*
 =09 * Mark this as IO
 =09 */
 =09vma->vm_page_prot =3D pgprot_noncached(vma->vm_page_prot);
=20
-=09if (remap_pfn_range(vma, vma->vm_start, phys,
+=09if (remap_pfn_range(vma, vma->vm_start, vma->vm_pgoff,
 =09=09=09     vma->vm_end - vma->vm_start,
 =09=09=09     vma->vm_page_prot))
 =09=09return -EAGAIN;
--=20
2.1.2

Re: [PATCH RFC 2/2] arm: kernel: fix pci_mmap_page_range() offset calculation

[Russell King - ARM Linux]

On Wed, Oct 15, 2014 at 01:03:41PM +0100, Lorenzo Pieralisi wrote:
> ARM relies on the standard implementation of pci_resource_to_user()
> which actually is an identity map and exports to user space
> PCI memory resources as they are stored in PCI devices resources (ie BARs)
> which represent CPU physical addresses (fixed-up using BUS to CPU
> address conversions) not PCI bus addresses.

This paragraph seems wrong.

It first says that PCI memory resources contain the same values that the
PCI device has in its BAR.  It then goes on to say that they are CPU
physical addresses.  That is not true.

For example, DC21285 systems always have done this as: the PCI bars
contain the _bus_ addresses, which tend to be in the range 0 to
0x7fffffff.  These correspond with a CPU physical address of
0x80000000 to 0xffffffff.  The PCI bus resources for IOMEM resources
contains the CPU physical address of the mapping.

> On platforms where the mapping between CPU and BUS address is not a 1:1
> mapping this is erroneous, in that an additional shift is applied to
> an already fixed-up offset passed from userspace.

Yes, I think this is a correct patch inspite of the description. :)

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

Re: [PATCH RFC 2/2] arm: kernel: fix pci_mmap_page_range() offset calculation

[Lorenzo Pieralisi]

Hi Russell,

thanks for having a look.

On Wed, Oct 15, 2014 at 11:29:32PM +0100, Russell King - ARM Linux wrote:
> On Wed, Oct 15, 2014 at 01:03:41PM +0100, Lorenzo Pieralisi wrote:
> > ARM relies on the standard implementation of pci_resource_to_user()
> > which actually is an identity map and exports to user space
> > PCI memory resources as they are stored in PCI devices resources (ie BARs)
> > which represent CPU physical addresses (fixed-up using BUS to CPU
> > address conversions) not PCI bus addresses.
> 
> This paragraph seems wrong.
> 
> It first says that PCI memory resources contain the same values that the
> PCI device has in its BAR.  It then goes on to say that they are CPU
> physical addresses.  That is not true.
> 
> For example, DC21285 systems always have done this as: the PCI bars
> contain the _bus_ addresses, which tend to be in the range 0 to
> 0x7fffffff.  These correspond with a CPU physical address of
> 0x80000000 to 0xffffffff.  The PCI bus resources for IOMEM resources
> contains the CPU physical address of the mapping.

It is a commit log wording problem, I exactly meant what you said, I
will reword it (or remove "ie BARs" from it, since it is misleading).

I think that the word "BAR" is a bit misused in helpers function like:

pci_resource_{start/end/len}

too but as long as we all know what that means (and I write proper
commit logs :)) it is all fine.

> > On platforms where the mapping between CPU and BUS address is not a 1:1
> > mapping this is erroneous, in that an additional shift is applied to
> > an already fixed-up offset passed from userspace.
> 
> Yes, I think this is a correct patch inspite of the description. :)

Great, I will reword it and wait for comments on patch 1 that changes
pci_mmap_fits() (it does not affect ARM, but would like to get both changes
in coherently - ie if I am asked to change patch 1 I will probably have
to change this patch too).

Thanks,
Lorenzo