Re: [PATCH v2 02/16] pci: quirks: add quirk to avoid AMD NL to bind with xhci

Bjorn Helgaas
2014-10-27T13:21:10Z

On Sun, Oct 26, 2014 at 8:55 PM, Huang Rui <ray.huang@amd.com> wrote:
> On Fri, Oct 24, 2014 at 10:35:29AM -0600, Bjorn Helgaas wrote:
>> On Fri, Oct 17, 2014 at 04:53:27PM +0800, Huang Rui wrote:

>> > +/* FIXME should define in <linux/pci_ids.h> */
>> > +#define PCI_DEVICE_ID_AMD_NL 0x7912
>>
>> If you KNOW this should be in linux/pci_ids.h (and it looks like it COULD
>> go there, since you do use the same definition in patch [01/16]), why don't
>> you just do it? Why are you wasting our time reviewing trivial stuff like
>> this?
>>
>
> Apology, I was told that it could not add device id into pci_ids.h
> from my buddy with below thread discussion last year, but I don't
> confirm at current. I check the git log at pci_ids.h, it looks like
> it's able to add device id marco again, is that right?
>
> http://marc.info/?l=linux-pci&m=137028614924258&w=2
>
> If I misunderstand your meaning, please correct me.

Just read the text at the beginning of pci_ids.h.

If you have to use the same ID in two different files, you should add
it to pci_ids.h.