Re: [PATCH v2 16/16] usb: dwc3: enable usb suspend phy

Felipe Balbi
2014-10-17T14:59:42Z

[-- Attachment #1: Type: text/plain, Size: 1448 bytes --]

Hi,

On Fri, Oct 17, 2014 at 04:53:41PM +0800, Huang Rui wrote:
> AMD NL needs to suspend usb3 ss phy, but this doesn't enable on simulation
> board.
>
> Signed-off-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/usb/dwc3/core.c | 7 ++++++-
> drivers/usb/dwc3/dwc3-pci.c | 3 ++-
> drivers/usb/dwc3/platform_data.h | 1 +
> 3 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 3ccfe41..4a98696 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -395,6 +395,9 @@ static void dwc3_phy_setup(struct dwc3 *dwc)
> if (dwc->quirks & DWC3_QUIRK_TX_DEEPH)
> reg |= DWC3_GUSB3PIPECTL_TX_DEEPH(1);
>
> + if (dwc->quirks & DWC3_QUIRK_SUSPHY)

should be:

if (!dwc->suspend_usb3_phy_quirk)

> + reg |= DWC3_GUSB3PIPECTL_SUSPHY;

IIRC, databook asks us to set that bit anyway, so the quirk is disabling
that bit. Am I missing something ? Paul ?

> diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> index 146eb2f..71401a3 100644
> --- a/drivers/usb/dwc3/dwc3-pci.c
> +++ b/drivers/usb/dwc3/dwc3-pci.c
> @@ -157,7 +157,8 @@ static int dwc3_pci_probe(struct pci_dev *pci,
> | DWC3_QUIRK_DEPOCHANGE
> | DWC3_QUIRK_LFPSFILT
> | DWC3_QUIRK_RX_DETOPOLL
> - | DWC3_QUIRK_TX_DEEPH;
> + | DWC3_QUIRK_TX_DEEPH
> + | DWC3_QUIRK_SUSPHY;

last patch

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]