* [PATCH] PCI: keystone: make local symbol static
@ 2014-10-23 2:10 Jingoo Han
2014-10-27 18:06 ` Murali Karicheri
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jingoo Han @ 2014-10-23 2:10 UTC (permalink / raw)
To: 'Bjorn Helgaas'
Cc: linux-pci, 'Jingoo Han', 'Murali Karicheri',
'Santosh Shilimkar'
Make local symbol static, because this is used only in this file.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pci/host/pci-keystone-dw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pci-keystone-dw.c
index 34086ce..4a97cd1 100644
--- a/drivers/pci/host/pci-keystone-dw.c
+++ b/drivers/pci/host/pci-keystone-dw.c
@@ -201,7 +201,7 @@ static int ks_dw_pcie_msi_map(struct irq_domain *domain, unsigned int irq,
return 0;
}
-const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = {
+static const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = {
.map = ks_dw_pcie_msi_map,
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: keystone: make local symbol static
2014-10-23 2:10 [PATCH] PCI: keystone: make local symbol static Jingoo Han
@ 2014-10-27 18:06 ` Murali Karicheri
2014-10-28 16:36 ` Santosh Shilimkar
2014-10-29 16:08 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Murali Karicheri @ 2014-10-27 18:06 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Bjorn Helgaas', linux-pci, 'Santosh Shilimkar'
On 10/22/2014 10:10 PM, Jingoo Han wrote:
> Make local symbol static, because this is used only in this file.
>
> Signed-off-by: Jingoo Han<jg1.han@samsung.com>
> ---
> drivers/pci/host/pci-keystone-dw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pci-keystone-dw.c
> index 34086ce..4a97cd1 100644
> --- a/drivers/pci/host/pci-keystone-dw.c
> +++ b/drivers/pci/host/pci-keystone-dw.c
> @@ -201,7 +201,7 @@ static int ks_dw_pcie_msi_map(struct irq_domain *domain, unsigned int irq,
> return 0;
> }
>
> -const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = {
> +static const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = {
> .map = ks_dw_pcie_msi_map,
> };
>
Jingoo Han,
Thanks for the patch.
Acked-by: Murali Karicheri <m-karicheri2@ti.com>
--
Murali Karicheri
Linux Kernel, Texas Instruments
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: keystone: make local symbol static
2014-10-23 2:10 [PATCH] PCI: keystone: make local symbol static Jingoo Han
2014-10-27 18:06 ` Murali Karicheri
@ 2014-10-28 16:36 ` Santosh Shilimkar
2014-10-29 16:08 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Santosh Shilimkar @ 2014-10-28 16:36 UTC (permalink / raw)
To: Jingoo Han, 'Bjorn Helgaas'
Cc: linux-pci, 'Murali Karicheri',
'Santosh Shilimkar'
On 10/22/2014 07:10 PM, Jingoo Han wrote:
> Make local symbol static, because this is used only in this file.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/pci/host/pci-keystone-dw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pci-keystone-dw.c
> index 34086ce..4a97cd1 100644
> --- a/drivers/pci/host/pci-keystone-dw.c
> +++ b/drivers/pci/host/pci-keystone-dw.c
> @@ -201,7 +201,7 @@ static int ks_dw_pcie_msi_map(struct irq_domain *domain, unsigned int irq,
> return 0;
> }
>
> -const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = {
> +static const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = {
> .map = ks_dw_pcie_msi_map,
> };
>
>
Looks correct.
FWIW, Acked-by: Santosh Shilimkar<ssantosh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: keystone: make local symbol static
2014-10-23 2:10 [PATCH] PCI: keystone: make local symbol static Jingoo Han
2014-10-27 18:06 ` Murali Karicheri
2014-10-28 16:36 ` Santosh Shilimkar
@ 2014-10-29 16:08 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2014-10-29 16:08 UTC (permalink / raw)
To: Jingoo Han
Cc: linux-pci, 'Murali Karicheri',
'Santosh Shilimkar'
On Thu, Oct 23, 2014 at 11:10:16AM +0900, Jingoo Han wrote:
> Make local symbol static, because this is used only in this file.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied to pci/host-keystone for v3.19 with acks from Murali and Santosh,
thanks!
> ---
> drivers/pci/host/pci-keystone-dw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pci-keystone-dw.c
> index 34086ce..4a97cd1 100644
> --- a/drivers/pci/host/pci-keystone-dw.c
> +++ b/drivers/pci/host/pci-keystone-dw.c
> @@ -201,7 +201,7 @@ static int ks_dw_pcie_msi_map(struct irq_domain *domain, unsigned int irq,
> return 0;
> }
>
> -const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = {
> +static const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = {
> .map = ks_dw_pcie_msi_map,
> };
>
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-29 16:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-23 2:10 [PATCH] PCI: keystone: make local symbol static Jingoo Han
2014-10-27 18:06 ` Murali Karicheri
2014-10-28 16:36 ` Santosh Shilimkar
2014-10-29 16:08 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).