From: Bjorn Helgaas <bhelgaas@google.com>
To: Yijing Wang <wangyijing@huawei.com>, g@google.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Xinwei Hu <huxinwei@huawei.com>, Wuyun <wuyun.wu@huawei.com>,
linux-arm-kernel@lists.infradead.org,
Russell King <linux@arm.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Subject: Re: [PATCH 00/10] Save MSI chip in pci_sys_data
Date: Tue, 11 Nov 2014 21:23:59 -0700 [thread overview]
Message-ID: <20141112042359.GK28161@google.com> (raw)
In-Reply-To: <1414396127-30023-1-git-send-email-wangyijing@huawei.com>
On Mon, Oct 27, 2014 at 03:48:37PM +0800, Yijing Wang wrote:
> Now PCI host bridge drivers in arm associate MSI chip and
> PCI bus by adding .add_bus(), and assign MSI chip pointer
> to every PCI bus. Associating MSI chip and every PCI bus
> is not necessary. All PCI busses under same PCI host brdige
> share the same MSI chip. So saving MSI chip in pci_sys_data
> is a better solution, it make PCI host bridge drivers clean.
> Because we still need to provide arch spec pcibios_msi_controller()
> to extract MSI controller pointer, a better solution is to
> refactor PCI host bridge, make a generic pci_host_bridge, and
> save common info like PCI domain number, MSI chip, resources
> in it. We will do that work in another series as soon.
>
> To Bjorn: Because struct msi_chip defined in struct hw_pci and pci_sys_data
> is under the #ifdef CONFIG_PCI_MSI, if we use if(IS_ENABLED(CONFIG_PCI_MSI))
> in PCI host bridge drivers, it will cause build errors when the CONFIG_PCI_MSI
> is off. So I keep #ifdef CONFIG_PCI_MSI in this series.
>
> Yijing Wang (10):
> MSI: Rename msi_chip to msi_controller for better readability
> PCI/MSI: Introduce weak pcibios_msi_controller()
> arm/MSI: Save MSI controller in pci_sys_data
> PCI: tegra: Save MSI controller in pci_sys_data
> PCI: designware: Save MSI controller in pci_sys_data
> PCI: rcar: Save MSI controller in pci_sys_data
> PCI: mvebu: Save MSI controller in pci_sys_data
> PCI: xilinx: Save MSI controller in pci_sys_data
> arm/PCI: Clean unused pcibios_add_bus() and pcibios_remove_bus()
> PCI/MSI: Remove useless bus->msi assignment
>
> arch/arm/include/asm/mach/pci.h | 10 +++++---
> arch/arm/kernel/bios32.c | 28 ++++++++++--------------
> drivers/irqchip/irq-armada-370-xp.c | 22 +++++++++---------
> drivers/of/of_pci.c | 40 +++++++++++++++++-----------------
> drivers/pci/host/pci-keystone-dw.c | 4 +-
> drivers/pci/host/pci-keystone.h | 2 +-
> drivers/pci/host/pci-mvebu.c | 14 ++++-------
> drivers/pci/host/pci-tegra.c | 37 +++++++++++++-------------------
> drivers/pci/host/pcie-designware.c | 25 +++++++--------------
> drivers/pci/host/pcie-designware.h | 2 +-
> drivers/pci/host/pcie-rcar.c | 37 +++++++++++++-------------------
> drivers/pci/host/pcie-xilinx.c | 27 +++++++----------------
> drivers/pci/msi.c | 22 ++++++++++++++-----
> drivers/pci/probe.c | 1 -
> include/linux/msi.h | 6 ++--
> include/linux/of_pci.h | 14 ++++++------
> include/linux/pci.h | 2 +-
> 17 files changed, 132 insertions(+), 161 deletions(-)
>
Applied to pci/msi for v3.19, thanks.
next prev parent reply other threads:[~2014-11-12 4:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 7:48 [PATCH 00/10] Save MSI chip in pci_sys_data Yijing Wang
2014-10-27 7:48 ` [PATCH 01/10] MSI: Rename msi_chip to msi_controller for better readability Yijing Wang
2014-10-27 7:48 ` [PATCH 02/10] PCI/MSI: Introduce weak pcibios_msi_controller() Yijing Wang
2014-10-27 7:48 ` [PATCH 03/10] arm/MSI: Save MSI controller in pci_sys_data Yijing Wang
2014-10-27 7:48 ` [PATCH 04/10] PCI: tegra: " Yijing Wang
2014-10-27 7:48 ` [PATCH 05/10] PCI: designware: " Yijing Wang
2014-10-27 7:48 ` [PATCH 06/10] PCI: rcar: " Yijing Wang
2014-10-27 7:48 ` [PATCH 07/10] PCI: mvebu: " Yijing Wang
2014-10-27 7:48 ` [PATCH 08/10] PCI: xilinx: " Yijing Wang
2014-10-27 7:48 ` [PATCH 09/10] arm/PCI: Clean unused pcibios_add_bus() and pcibios_remove_bus() Yijing Wang
2014-10-27 7:48 ` [PATCH 10/10] PCI/MSI: Remove useless bus->msi assignment Yijing Wang
2014-11-12 4:24 ` Bjorn Helgaas
2014-11-12 5:54 ` Yijing Wang
2014-11-12 4:23 ` Bjorn Helgaas [this message]
2014-11-17 2:59 ` [PATCH 00/10] Save MSI chip in pci_sys_data Bjorn Helgaas
2014-11-17 9:38 ` Thomas Gleixner
2014-11-17 16:54 ` Bjorn Helgaas
2014-11-17 21:02 ` Thomas Gleixner
2014-11-17 21:27 ` Bjorn Helgaas
2014-11-17 21:31 ` Thomas Gleixner
2014-11-18 17:53 ` Marc Zyngier
2014-11-21 17:20 ` Bjorn Helgaas
2014-11-22 2:58 ` Yijing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112042359.GK28161@google.com \
--to=bhelgaas@google.com \
--cc=g@google.com \
--cc=huxinwei@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wangyijing@huawei.com \
--cc=wuyun.wu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).