From: Bjorn Helgaas <bhelgaas@google.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-pci@vger.kernel.org, 'Kishon Vijay Abraham I' <kishon@ti.com>
Subject: Re: [PATCH V2] PCI: dra7xx: Add dra7xx prefix before add_pcie_port
Date: Thu, 13 Nov 2014 09:42:32 -0700 [thread overview]
Message-ID: <20141113164232.GB5064@google.com> (raw)
In-Reply-To: <001c01cff982$d2e4fa00$78aeee00$%han@samsung.com>
On Thu, Nov 06, 2014 at 02:30:49PM +0900, Jingoo Han wrote:
> The add_pcie_port function is dra7xx-specific. Add dra7xx prefix
> to avoid collision in global name space.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
Applied to pci/host-dra7xx for v3.19, thanks!
> ---
> - Replace 'exynos' typo with 'dra7xx' in the commit message.
> - Added Kishon's Acked-by.
>
> drivers/pci/host/pci-dra7xx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
> index 52b34fe..5b4a644 100644
> --- a/drivers/pci/host/pci-dra7xx.c
> +++ b/drivers/pci/host/pci-dra7xx.c
> @@ -270,8 +270,8 @@ static irqreturn_t dra7xx_pcie_irq_handler(int irq, void *arg)
> return IRQ_HANDLED;
> }
>
> -static int add_pcie_port(struct dra7xx_pcie *dra7xx,
> - struct platform_device *pdev)
> +static int dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
> + struct platform_device *pdev)
> {
> int ret;
> struct pcie_port *pp;
> @@ -398,7 +398,7 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, dra7xx);
>
> - ret = add_pcie_port(dra7xx, pdev);
> + ret = dra7xx_add_pcie_port(dra7xx, pdev);
> if (ret < 0)
> goto err_add_port;
>
> --
> 1.7.9.5
>
>
prev parent reply other threads:[~2014-11-13 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 1:11 [PATCH] PCI: dra7xx: Add dra7xx prefix before add_pcie_port Jingoo Han
2014-11-06 5:06 ` Kishon Vijay Abraham I
2014-11-06 5:27 ` Jingoo Han
2014-11-06 5:30 ` [PATCH V2] " Jingoo Han
2014-11-13 16:42 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113164232.GB5064@google.com \
--to=bhelgaas@google.com \
--cc=jg1.han@samsung.com \
--cc=kishon@ti.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).