* [PATCH] PCI: dra7xx: Add dra7xx prefix before add_pcie_port
@ 2014-11-06 1:11 Jingoo Han
2014-11-06 5:06 ` Kishon Vijay Abraham I
2014-11-06 5:30 ` [PATCH V2] " Jingoo Han
0 siblings, 2 replies; 5+ messages in thread
From: Jingoo Han @ 2014-11-06 1:11 UTC (permalink / raw)
To: 'Bjorn Helgaas'
Cc: linux-pci, 'Kishon Vijay Abraham I', 'Jingoo Han'
The add_pcie_port function is dra7xx-specific. Add exynos prefix
to avoid collision in global name space.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pci/host/pci-dra7xx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
index 52b34fe..5b4a644 100644
--- a/drivers/pci/host/pci-dra7xx.c
+++ b/drivers/pci/host/pci-dra7xx.c
@@ -270,8 +270,8 @@ static irqreturn_t dra7xx_pcie_irq_handler(int irq, void *arg)
return IRQ_HANDLED;
}
-static int add_pcie_port(struct dra7xx_pcie *dra7xx,
- struct platform_device *pdev)
+static int dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
+ struct platform_device *pdev)
{
int ret;
struct pcie_port *pp;
@@ -398,7 +398,7 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, dra7xx);
- ret = add_pcie_port(dra7xx, pdev);
+ ret = dra7xx_add_pcie_port(dra7xx, pdev);
if (ret < 0)
goto err_add_port;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] PCI: dra7xx: Add dra7xx prefix before add_pcie_port
2014-11-06 1:11 [PATCH] PCI: dra7xx: Add dra7xx prefix before add_pcie_port Jingoo Han
@ 2014-11-06 5:06 ` Kishon Vijay Abraham I
2014-11-06 5:27 ` Jingoo Han
2014-11-06 5:30 ` [PATCH V2] " Jingoo Han
1 sibling, 1 reply; 5+ messages in thread
From: Kishon Vijay Abraham I @ 2014-11-06 5:06 UTC (permalink / raw)
To: Jingoo Han, 'Bjorn Helgaas'; +Cc: linux-pci
On Thursday 06 November 2014 06:41 AM, Jingoo Han wrote:
> The add_pcie_port function is dra7xx-specific. Add exynos prefix
> to avoid collision in global name space.
%s/exynos/dra7xx
After fixing this you can add
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/pci/host/pci-dra7xx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
> index 52b34fe..5b4a644 100644
> --- a/drivers/pci/host/pci-dra7xx.c
> +++ b/drivers/pci/host/pci-dra7xx.c
> @@ -270,8 +270,8 @@ static irqreturn_t dra7xx_pcie_irq_handler(int irq, void *arg)
> return IRQ_HANDLED;
> }
>
> -static int add_pcie_port(struct dra7xx_pcie *dra7xx,
> - struct platform_device *pdev)
> +static int dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
> + struct platform_device *pdev)
> {
> int ret;
> struct pcie_port *pp;
> @@ -398,7 +398,7 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, dra7xx);
>
> - ret = add_pcie_port(dra7xx, pdev);
> + ret = dra7xx_add_pcie_port(dra7xx, pdev);
> if (ret < 0)
> goto err_add_port;
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] PCI: dra7xx: Add dra7xx prefix before add_pcie_port
2014-11-06 5:06 ` Kishon Vijay Abraham I
@ 2014-11-06 5:27 ` Jingoo Han
0 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2014-11-06 5:27 UTC (permalink / raw)
To: 'Kishon Vijay Abraham I', 'Bjorn Helgaas'
Cc: linux-pci, 'Jingoo Han'
On Thursday, November 06, 2014 2:07 PM, Kishon Vijay Abraham I wrote:
>
> On Thursday 06 November 2014 06:41 AM, Jingoo Han wrote:
> > The add_pcie_port function is dra7xx-specific. Add exynos prefix
> > to avoid collision in global name space.
>
> %s/exynos/dra7xx
Sorry, it is my bad. I will send patch v2 soon.
>
> After fixing this you can add
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
I appreciated you Acked-by.
Best regards,
Jingoo Han
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > drivers/pci/host/pci-dra7xx.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V2] PCI: dra7xx: Add dra7xx prefix before add_pcie_port
2014-11-06 1:11 [PATCH] PCI: dra7xx: Add dra7xx prefix before add_pcie_port Jingoo Han
2014-11-06 5:06 ` Kishon Vijay Abraham I
@ 2014-11-06 5:30 ` Jingoo Han
2014-11-13 16:42 ` Bjorn Helgaas
1 sibling, 1 reply; 5+ messages in thread
From: Jingoo Han @ 2014-11-06 5:30 UTC (permalink / raw)
To: 'Bjorn Helgaas'
Cc: linux-pci, 'Kishon Vijay Abraham I', 'Jingoo Han'
The add_pcie_port function is dra7xx-specific. Add dra7xx prefix
to avoid collision in global name space.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
---
- Replace 'exynos' typo with 'dra7xx' in the commit message.
- Added Kishon's Acked-by.
drivers/pci/host/pci-dra7xx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
index 52b34fe..5b4a644 100644
--- a/drivers/pci/host/pci-dra7xx.c
+++ b/drivers/pci/host/pci-dra7xx.c
@@ -270,8 +270,8 @@ static irqreturn_t dra7xx_pcie_irq_handler(int irq, void *arg)
return IRQ_HANDLED;
}
-static int add_pcie_port(struct dra7xx_pcie *dra7xx,
- struct platform_device *pdev)
+static int dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
+ struct platform_device *pdev)
{
int ret;
struct pcie_port *pp;
@@ -398,7 +398,7 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, dra7xx);
- ret = add_pcie_port(dra7xx, pdev);
+ ret = dra7xx_add_pcie_port(dra7xx, pdev);
if (ret < 0)
goto err_add_port;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH V2] PCI: dra7xx: Add dra7xx prefix before add_pcie_port
2014-11-06 5:30 ` [PATCH V2] " Jingoo Han
@ 2014-11-13 16:42 ` Bjorn Helgaas
0 siblings, 0 replies; 5+ messages in thread
From: Bjorn Helgaas @ 2014-11-13 16:42 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-pci, 'Kishon Vijay Abraham I'
On Thu, Nov 06, 2014 at 02:30:49PM +0900, Jingoo Han wrote:
> The add_pcie_port function is dra7xx-specific. Add dra7xx prefix
> to avoid collision in global name space.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
Applied to pci/host-dra7xx for v3.19, thanks!
> ---
> - Replace 'exynos' typo with 'dra7xx' in the commit message.
> - Added Kishon's Acked-by.
>
> drivers/pci/host/pci-dra7xx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
> index 52b34fe..5b4a644 100644
> --- a/drivers/pci/host/pci-dra7xx.c
> +++ b/drivers/pci/host/pci-dra7xx.c
> @@ -270,8 +270,8 @@ static irqreturn_t dra7xx_pcie_irq_handler(int irq, void *arg)
> return IRQ_HANDLED;
> }
>
> -static int add_pcie_port(struct dra7xx_pcie *dra7xx,
> - struct platform_device *pdev)
> +static int dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
> + struct platform_device *pdev)
> {
> int ret;
> struct pcie_port *pp;
> @@ -398,7 +398,7 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, dra7xx);
>
> - ret = add_pcie_port(dra7xx, pdev);
> + ret = dra7xx_add_pcie_port(dra7xx, pdev);
> if (ret < 0)
> goto err_add_port;
>
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-13 16:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-06 1:11 [PATCH] PCI: dra7xx: Add dra7xx prefix before add_pcie_port Jingoo Han
2014-11-06 5:06 ` Kishon Vijay Abraham I
2014-11-06 5:27 ` Jingoo Han
2014-11-06 5:30 ` [PATCH V2] " Jingoo Han
2014-11-13 16:42 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).